At 2017-04-22T07:13:38-0700, Sean Whitton wrote: > control: tag -1 +moreinfo > > Hello Branden, > > I can't get 79e8ccf40499ace8cf36210a7ad9fb157209bbe4 to build. Log > attached. Urp. This is due to the unavailabilty of gropdf on the build host, it looks like. I'll investigate. > Given this problem I haven't done a full review, but I'd like to make > two preliminary suggestions: > > 1) How about merging the -1, -2 and -3~~unreleased changelog entries > into a single entry, since we're doing a single upload? Won't that prompt the question of what happened to -1 and -2? Or do you mean renumber -3 as -1? And move the git tags? > 2) You have made a very large number of changes to the upstream source > by means of debian/patches. How about separating the changelog into two > sections, something like this: > > Debian packaging changes: > * Migrate to new (to me) quilt-based Debian source format 3.0. > + Migrate former contents of debian/patches to debian/patch/*; dropping > patches now merged upstream. > [...] > > Debian patches to upstream source: > * Makefile: Observe LDFLAGS when building internal "compile_rom" tool. > Thanks to Graham Inggs for the discussion! (Closes: #859751) > [...] > > Also, could you confirm that your changes have been forwarded upstream? Yes, I emailed some of them to Tim Mann on 3 April, and the rest on 17 April. I think there were some cosmetic changes to the man pages after that. > If you're able to address the issues I've raised in this message, please > remove the moreinfo tag in this bug, and don't forget to re-run `dch -r` > to refresh the changelog timestamp. Will do. Regards, Branden
Attachment:
signature.asc
Description: PGP signature