On Tue, 18 Apr 2017 20:13:55 +0900 Roger Shimizu <rogershimizu@gmail.com> wrote: > Interesting package! > Actually it looks like usbguard (already in stretch) + LDAP + PAM. > > Could you kindly push your packaging code to some SCM, such as github? > This could make the review easier. Thank you! I cannot sponsor your package. But still wish you find my review helpful. Hope you can fix these and put your work in some SCM. Thank you! - d/copyright: MIT license has some variants, so it's better to specify as Expat license. - d/*-docs: Better to add README.md here - d/usbwalld.default should cleanup non-effective comments - d/usbwalld.service for document, you should use man page, not a URL. you can also take my package shadowsocks-libev as reference. - d/libpam-usbwall.install please replace x86_64-linux-gnu with *, or you will have FTBFS from all arch except amd64 - d/patches: please upstream your 2 patches - you have init script, so I guess you need to add Depends: lsb-base (>= 3.0-6) - d/rules: need cleanup. Some above are not required, but quite simple to fix. Thanks for your work! Cheers, -- Roger Shimizu, GMT +9 Tokyo PGP/GPG: 4096R/6C6ACD6417B3ACB1
Attachment:
pgpoILvR3eDCW.pgp
Description: PGP signature