[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#849273: RFS: gemmlowp/0~20161216-gb56df4a-1 [ITP]



Control: tag -1 -moreinfo

> I cannot sponsor the upload, just a few comments after reviewing your package.
>
> I see some activities on your PR on github:
>  - https://github.com/google/gemmlowp/pull/63
> So you're going to update the CMakeLists.txt based on upstream's feedback?

I can help upstream to maintain this cmake file.

> Others are all nitpicking (not required):
> - In favor of https URL over http in debian/copyright

left unchanged. The http links comes from template.

> - no need to depends on ${shlibs:Depends}, since there's no real library?
>   dpkg-gencontrol: warning: Depends field of package gemmlowp-dev:
> unknown substitution variable ${shlibs:Depends}

removed.

Thanks for your review. :-)


Reply to: