[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#858860: RFS: arpwatch [ITA]



Hi Christian, Lukas,

> It does solve the problem (i.e. the error is gone if `usr/sbin` is
> present in the `dirs` file).  According to the Debian New Maintainers'
> Guide guide, creating directories that are not created by
> `make install DESTDIR=...` as invoked by dh_auto_install is exactly
> what the dirs file is for [1].

right :)

> Also, running `dh binary --no-act` in the arpwatch packaging dir yields:
> $ dh binary --no-act
>    (...)
>    dh_installdirs
>    dh_auto_install
>    (...)
> 
> 
> Can you explain in which situations dh_installdirs will be run after
> dh_auto_install? 

As far as I am aware, dh_installdirs in always executed before dh_auto_install.
This is also what the Debian New Maintainer's Guide suggests[0].

> I'd like to avoid messing with the upstream build system more than
> required.  If dh_installdirs isn't the correct approach, maybe I can
> create an override_dh_auto_install target and create the directory
> there before calling dh_auto_install…?

I'd say using dirs is fine.

Alternatively you could probably patch the Makefile like that:

--- a/Makefile.in       2017-04-05 18:04:48.110827892 +0200
+++ b/Makefile.in       2017-04-05 18:04:48.106828088 +0200
 @@ -111,7 +111,7 @@
        $(CC) $(CFLAGS) $(LDFLAGS) -o $@ zap.o intoa.o -lutil
 
  install: force
-       $(INSTALL) -m 555 -o bin -g bin arpwatch $(DESTDIR)$(BINDEST)
+       mkdir -p "$(DESTDIR)" && $(INSTALL) -m 555 -o bin -g bin arpwatch $(DESTDIR)$(BINDEST)
        $(INSTALL) -m 555 -o bin -g bin arpsnmp $(DESTDIR)$(BINDEST)

 install-man: force

Cheers,
 Hugo

[0] https://www.debian.org/doc/manuals/maint-guide/dreq.en.html#rules

-- 
             Hugo Lefeuvre (hle)    |    www.owl.eu.com
4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E

Attachment: signature.asc
Description: PGP signature


Reply to: