Bug#858795: RFS: python-zxcvbn/4.4.14-1 [ITA]
Hello again!
>I don't understand this change
the previous entry is UNRELEASED, just remove
it
something like
[ yourname ]
* fixed a
* new release b
* fixed b
[ the other developer ]
* changed VCS stuff (keep the message entry)
-- signature
>I compiled the new version of the porting, what else should I write?
I see lots of changes in the packaging, e.g.
compat level
lots in control file
dependencies, new packages
do you think end users shouldn't be aware of the new Python3 port?
changelog is read by lots of users, so please be verbose here.
*every* packaging change has to be mentioned here
(specially when it can have impact on the user experience)
better safe then sorry
>I would not do it, but I don't know how to join the team
https://wiki.debian.org/Teams/PythonModulesTeam
>> 3) the syntax of zxcvbn (the instantiation as example), changed a lot in this fork.
>> Did you check reverse dependencies?
>yes, no reverse dependencies found
in Debian. People relies on Python scripts that have no strict dependencies (no ldd, runtime
libraries), so they break really easily with such changes
I would probably add a NEWS file (google for it), so during the upgrade a warning is prompted
to the end user
https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html
additional review:
you removed the README from docs...
what about adding the README.rst?
(or convert it to something different, I don't actually know)
this is everything for now, wrt source package the above requested changes should be complete
I still need to test the package, but it should be good now
(the first review is always the most painful for both of us :) )
BTW it is nice that upstream removed a lot of stuff in this release,
and the copyright looks really better now!
cheers!
Gianfranco
Reply to: