Bug#845710: removed Vcs fields

[Roger Shimizu <rogershimizu@gmail.com>]

On Mon, Feb 27, 2017 at 5:07 AM, Tim Kuijsten <tim@netsend.nl> wrote:
>
> For the sake of simplicity I have added the debian directory to my main repository. Hope this is good enough.

Thanks for add back debian folder!

I was wondering where's the git repository, and finally found it in
your original RFS email.
So you're also upstream. awesome!

I cannot sponsor the upload, but here's my review and hope you find it helpful.

 - debian/copyright
   * according to
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
     "There are many versions of the MIT license. Please use Expat
instead, when it matches."
     So please avoid using "MIT" as license.
   * main.css is under a different license, which should be mentioned
 - lintian reports two hardening info level message
   * I guess you can add $(CPPFLAGS) to Makefile to fix it
 - debian/control
   * debhelper / compat recommend >=10
   * better if line separated + sorted Build-Depends list (easy to
maintain afterwrads)
 - debian/rules
   * why do you disable the test?

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1