Bug#849273: RFS: gemmlowp/0~20161216-gb56df4a-1 [ITP]
Control: tag -1 +moreinfo
Dear lumin,
On Sat, Dec 24, 2016 at 11:44 PM, lumin <cdluminate@gmail.com> wrote:
>
> * Package name : gemmlowp
> Version : 0~20161216-gb56df4a-1
Thanks for your clean packaging!
I cannot sponsor the upload, just a few comments after reviewing your package.
I see some activities on your PR on github:
- https://github.com/google/gemmlowp/pull/63
So you're going to update the CMakeLists.txt based on upstream's feedback?
Others are all nitpicking (not required):
- In favor of https URL over http in debian/copyright
- no need to depends on ${shlibs:Depends}, since there's no real library?
dpkg-gencontrol: warning: Depends field of package gemmlowp-dev:
unknown substitution variable ${shlibs:Depends}
Cheers,
--
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1
Reply to: