Bug#840739: RFS: gudhi/1.3.1+ds-1 [ITP]

[Roger Shimizu <rogershimizu@gmail.com>]

Control: tag -1 +moreinfo

Dear Gard,

On Fri, Oct 14, 2016 at 7:32 PM, Gard Spreemann <gspreemann@gmail.com> wrote:
>
> I am looking for a sponsor for my package "gudhi"
>
>  * Package name      : gudhi
>    Version           : 1.3.1+ds-1
>    Upstream Author   : Gudhi Project / INRIA
>  * URL               : http://gudhi.gforge.inria.fr/
>  * License           : GPL3+
>    Section           : math
>
> GUDHI is a C++ header-only template library for computations in the
> mathematical field of topological data analysis.

I cannot sponsor the upload. But here's my review that I hope it's helpful.

Here're the items need to be fixed:
- missing in debian/copyright, not GPL-3+ license:
    cmake/modules/FindEigen3.cmake
    cmake/modules/FindTBB.cmake
    include/gudhi/Contraction/CGAL_queue/*.h
    data/points/COIL_database/images/*
    doc/*/*.png
  Better to ask upstream to confirm license of those image files.
Usually license of image files is different from the code. If it's not
sure simply remove it from "debian source" repack.

- lintian reports:
    I: libgudhi-dev: spelling-error-in-copyright unneccessary unnecessary

Other comments, nice to have:
 - it's more convenient if you can export your work to some modern
SCM, such as git
   the review will be easier if doing with such SCM
   you can omit the final releasing commit, so if there's something
still need to work, you don't have to push forcefully.
 - add Vcs-* line to d/control (depends on the above item)
 - bump to debhelper 10
 - wrap and sort Build-Depends & Depends list in d/control
 - have separated -doc package
 - even upstream didn't provide script to install example, you can
install those example files by adding d/docs file
 - In favor of https URL over http in debian/copyright

So far it's enough for now.

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1