[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#850942: RFS: pydbus/0.6.0-1



X-Debbugs-Cc: debian-python@lists.debian.org
control: tags -1 - moreinfo

Hi Giovani,

Thank you for your review and your detailed report.


On Wed, 2017-01-11 at 23:52 -0200, Giovani Ferreira wrote:
> d/changelog:
> - Even the transition to testing is 10 days, you can keep urgency=medium, 
> this is the default.

OK. 

> - Please specify the files that have changed or removed (eg: debian/copyright).

Done
https://anonscm.debian.org/git/python-modules/packages/pydbus.git/commit/?id=549686


> d/control e d/compat:
> - Please update debhelper to version 10.

Done
https://anonscm.debian.org/git/python-modules/packages/pydbus.git/commit/?id=4169b9

> - Still in d/control you can update in the Vcs-Browser address from "cgit" 
> to "git".

Done
https://anonscm.debian.org/git/python-modules/packages/pydbus.git/commit/?id=5f5f08

> d/copyright:
> - What do you think about aligning the copyright years in the 
> doc/tutorial.rst block? You could add the email Linus in this block too.

Aligned. I agree, it looks better now :)
https://anonscm.debian.org/git/python-modules/packages/pydbus.git/commit/?id=e3c41a

I did not add Linus' email because I used the copyright as indicated in
the document verbatim. I will stick to that unless you see a problem
with it.

> d/rules:
> - Remove the first lines of comments, this is not necessary.

Done
https://anonscm.debian.org/git/python-modules/packages/pydbus.git/commit/?id=efadc8

> d/watch:
> - Please, update to version 4.

Done
https://anonscm.debian.org/git/python-modules/packages/pydbus.git/commit/?id=28058f


I have reuploaded the package to
https://mentors.debian.net/package/pydbus


Thank you. Best regards,

-- 
Alberto Caso 

Servicio de Implantación de Sistemas.
Dir. Gral. de Administración Electrónica y Tecnologías de la
Información.
Consejería de Hacienda y Administración Pública.
Junta de Extremadura.


Reply to: