[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#850664: RFS: python-pynzb/0.1.0-3



control: tag -1 +moreinfo

Dear Carl,

On Mon, Jan 09, 2017 at 12:56:51PM +1100, Carl Suster wrote:
> I am looking for a sponsor for my package "python-pynzb"

Thank you for your interest!

>  The Python 2 module can still be built fine, but I removed it since
> there were no rdeps.

As in my reponse to your other RFS, I'd like to confirm that this is
DPMT policy.

> Changes since the last upload:
>
>   * 0001-set-message_id-properly-in-expat-parser.patch: fix an upstream code.
>     Tests pass for Python 2 with only this change.

Your grammar is misleading.  ITYM "Tests pass for Python 2 only with
this change."

>   * Move lxml to Suggests since there are fallbacks, but Build-Depend on it to
>     run the tests.

It would be clearer to split this into two changlog entries, i.e.

    * Move lxml to Suggests [from ??].
    * Add build-dep on lxml to run the tests.

>   * For Python 3, decode strings -> bytes as utf-8 for lxml.

How did you make this change?  With a patch to the upstream code?
Please explain.

>   * Fix watch file (although the last release was some time ago).

Please consider dropping the parathetical remark.  It's not really
appropriate for a packaging changelog.

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: