Bug#849521: RFS: rutorrent/3.7-1 [ITP] -- A front-end for the rTorrent torrent client
Hello Taylor Kline,
On Tue, Dec 27, 2016 at 11:26:30PM -0500, Taylor Kline wrote:
> Package: sponsorship-requests
> Severity: wishlist
>
> Hello fine mentors,
>
> I am looking for a sponsor for "rutorrent"
>
> Package name : rutorrent
> Version : 3.7-1
[...]
>
> /etc/ruTorrent - server files
>
> /usr/share/ruTorrent - user-set configuration files chmod'd to a+rwX
[...]
Thanks for being upfront with this, appreciated.
I've looked over your package which I think mostly looks good.
I'm not overly joyed by seeing the symlink farm in /etc pointing
to /usr/share though. This is simply wrong as the files are
not configuration files (which is why they don't live in
/etc to begin with). Whatever needs these files should IMHO
be fixed up to look for the in the correct location (so
you can drop the symlinks).
Making /usr/share/ruTorrent world-writable is the main issue though.
This will never end well. You need to think about security and
how you manage permissions somehow. This is in my opinion a
blocker for uploading your package.
Please also consider upstreaming your manpages.
Not sure but if nginx has '*-available' '*-enabled' configuration
pattern but I think it does and then maybe there's a way to
provide a snippet for '*-available' that a user can in normal
cases just enable. This should simplify for the user over having
to read up and manually configure nginx.
Regards,
Andreas Henriksson
Reply to: