On 29/12/16 08:40, Sean Whitton wrote:
control: tag -1 +moreinfo control: owner -1 ! Dear Ghislain, On Wed, Dec 28, 2016 at 09:47:09PM +0000, Ghislain Vaillant wrote:I am looking for a sponsor for my package "numpydoc"I can sponsor this for you, but I'd like to ask you to improve your changelog a bit -- see below.Changes since the last upload: * Team upload [ Ondřej Nový ] * Fixed VCS URL (https) [ Ghislain Antony Vaillant ] * Filter upstream tarball from vendored sphinx.ext.linkcodeWhy? It's not explained anywhere why this was necessary. It would be good if you could note it in the changelog.
sphinx.ext.linkcode -> because it is already in Sphinx? Isn't this explicit enough?
* New upstream release * Update copyright file * Bump versioned depends on Python to 2.7 and 3.4 * Bump standards version to 3.9.8, no changes required * Add packaging testsuiteNot clear what "packaging" means. Maybe s/packaging/autopkgtest/
You are the first sponsor who has had problems with this terminology. I use packaging testsuite as the testsuite associated to the packaging, as opposed to the upstream testsuite associated to the upstream code.
Anyway, let me know whether this is *really* a deal breaker.
* Rearrange copyright paragraphs to fix Lintian warnings * Add build dependency on dh-pythonWhy? Maybe s/Add/Add missing/
Sure, why not.
* Improve description of the Python 2 binary package * cme fix dpkg-control: - Drop versioned dependency on python-all - Drop versioned dependency on python[,3]-sphinx - Wrap and sort * cme fix dpkg-copyright: use HTTPS URI in Format fieldnote to self: checked diff from archive to 0dec799
If there is more reviewing to come, please consider doing it now. My time working on other team-maintained packages is very limited (so is probably your sponsorship time) and I would appreciate limiting the number of email iterations to accelerate the process.
Many thanks, Ghis