[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#846306: RFS: ondir/0.2.3+git0.55279f03-1 [ITP]



On Thu, Dec 22, 2016 at 12:29:23PM +0100, Christian Seiler wrote:
> Hi Gianfranco,
> 
> Thanks for taking care of this.
> 
> On 12/22/2016 12:05 PM, Gianfranco Costamagna wrote:
[snip]
> > why override dh_auto_build and dh_auto_install?
> > probably exporting LDFLAGS and CFLAGS should work
> 
> No, it won't, because I have to override the variables in the
> Makefile.
> 
> For a simple example, take the following Makefile:
[snip]
> 
> If one uses cmake or autoconf or similar, then environment variables
> are sufficient. If the Makefile uses ?= to set the environment variables,
> then as well. But since upstream's Makefile uses a plain and = for the
> assignment of the environment variable, we need to override that
> explicitly via an argument to make.

That's why I always add a patch to the Makefile that changes the "=" to
"?=" and then send it upstream; so far the upstream authors have always
accepted such trivial yet quite useful patches :)

G'luck,
Peter

-- 
Peter Pentchev  roam@ringlet.net roam@FreeBSD.org pp@storpool.com
PGP key:        http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint 2EE7 A7A5 17FC 124C F115  C354 651E EFB0 2527 DF13

Attachment: signature.asc
Description: PGP signature


Reply to: