Control: tags -1 - moreinfo Hi Tobias, On 2016-12-18 22:24+0100, Tobias Frost wrote: > (I won't sponsor this because I will not find time to do so before the > Stretch-Window will close, except you'll be very fast in providing an > updated package; Any other DD can/should grab this package if wanted) I'll try to be as fast as I can :-). > some remarks: > > - d/changelog does not contain the changelog entry of the NMU 1.1.11- > 1.1 and seems so also not the changes by this NMU Sorry about this! I guess I just imported the package from the maintainer VCS. I've added the changelog entry, but not the patch, as it is not needed anymore. > - there is no announcement of the NMU on the BTS. Did you try to > contact the Maintainer? As stated in the RFS, I did this privately two weeks before I filled the RFS. I can forward it there if needed. That's my first NMU, so I'm not sure about the announcement on the BTS. What should I do there? > - the changelog should be more verbose. E.g "remove unused patch" > -- should list which ones? There are undocumented changes. I fixed this in the new package I just uploaded to mentors. > -- CFLAGS += `dpkg-buildflags --get CPPFLAGS` looks wrong What should be set there? I added this because I had a warning by blhc during the build related to this, and the doc I found about hardening build flags recommended to add this. > (please remove the moreinfo tag once the package is improved. > Please make sure to try to contact the maintainer, best using the BTS) I added Jose in Cc: of this email. Thanks for your review, and I hope you'll find time to answer my questions!
Attachment:
signature.asc
Description: PGP signature