[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#847458: RFS: clues-emacs/0~2014.09.23.69d873c-1 ITP



control: tag -1 +confirmed
control: noowner -1

f95bd4552f6c9922754ac72deec139ab70fa5d28 ready for upload.

On Sat, Dec 10, 2016 at 12:11:29PM +0300, Dmitry Bogatov wrote:
> I did not checked, that (package-initialize) is really needed, but I
> assume you are right.
> 
> But probably it should be installed by dh-elpa?  For example, upstream
> name 'clues-theme', which is written in d/copyright is rather reliable
> signal, that package is theme.
> 
> Since right now I am EBUSY to write patch for dh-elpa, I agree with your
> commit.

For normal packages, dh-elpa autoloads functions, so you don't need to
call (package-initialize).  However, AIUI, you can't autoload themes.
So this is a limitation in upstream Emacs, rather than something to
patch in dh-elpa.

> > 1. It would be good to file a bug upstream asking for a tagged stable
> > release.
> 
> I wrote email to upstream. Since no changes are made since 2014, I have
> doubts that I will receive reply

Fair enough.

> > 2. How about installing clues-theme.png, and patching README.md to
> > refer to it?
> 
> Not done. Why would you need screen-shot, if you have theme already installed?

Fine.  It's my personal preference to install screenshots as someone
might find them useful, but fair enough if you disagree.

> > 6. Please use https:// not git:// in d/watch.
> 
> Fixed. See more.
> 
> It was created by dh-make-elpa. Unfortunately, I forgot --pkg-emacsen flag.
> Two questions:
> 
>  - why dh-make-elpa generates different d/watch for --pkg-emacsen debianization?

Definitely a bug.  Since you know exactly what triggered the bug, would
you file it against dh-make-elpa, please?

>  - why --pkg-emacsen is not default?

It's meant to be a general tool for making Debian source packages, not
only for pkg-emacsen members.

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: