[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#847350: RFS: golang-github-minio-minio-go/2.0.2+dfsg-1



On Wednesday, 7 December 2016 6:02:33 PM AEDT Gianfranco Costamagna wrote:
> repacking to drop bundled dependencies is sometimes called ds (Debian
> Source) repack, non dfsg (even if nobody ever wrote some documentation for
> this).

I think "ds" is quite confusing let alone that it matches my initials. ;)
IMHO DFSG-repacking fits all cases even when we throw away useless files to 
avoid documenting their copyrights. Often you just don't know whether 
excluded content is DFSG compliant or not. And since removing bundled 
libraries is policy compliance I believe DFSG is the appropriate suffix to 
use in repacked tarballs.


> If you prefer a dfsg tarball, it is fine for me,
> but I don't get why you
> used debian/clean to remove such files,

I thought "debian/clean" is an unrelated issue... What about "debian/clean"?
I sometimes remove 3rd party dependencies from "debian/clean" as well (not in 
this package as I recall). You may say it is redundant but actually it is 
useful if/when you re-build from non-repacked tarball or checkout of upstream 
repository.

Here I think "debian/clean" was used merely to drop some tests (instead of 
patching 'em which would be more difficult).


> and now you want a source repack.

Only if there are bundled 3rd party libraries. Repacking is very common for 
Golang packages -- even dh-make-golang does that by default and it does not 
indicate that something was thrown away neither by adding "ds" nor "dfsg" to 
version...


> Not sure if I got it correctly, but the removal of the tests has nothing
> to do with bundled dependencies, but more a "remove tests that we can't
> run on Debian infrastructure".

Correct.


> Can you please explain again your point?
> I admit I worked only a little on golang-* packages, and I would like to
> learn something more :)

I'm sorry I think I've lost the context... Could you please ask your question 
again and I'll do my best to explain.

> (btw feel free to cancel/reschedule, or tell me what to do with this
> upload)

Thank for your help, Gianfranco. I did not have a chance to look at the 
current state of the package yet. I'll see if I can have a look later today.

-- 
All the best,
 Dmitry Smirnov.

---

Good luck happens when preparedness meets opportunity.

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: