[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#843430: RFS: ocrmypdf/4.3-1



control: owner -1 !
control: tag -1 moreinfo

On Sun, Nov 06, 2016 at 09:59:01AM -0700, Sean Whitton wrote:
> I normally upload ocrmypdf with dgit, so I'd like to request sponsorship
> using dgit so that the git history on dgit-repos is not interrupted.

As I said, I'm interested in trying out dgit and at least understanding
it more, so I'm doing this.

First, a small review:

* be aware that I'm morally opposed to --link-doc, so good thing you
  reverted that..
* policy 3.9.7 recommend to install the docs in /usr/share/doc/$mainpkg
  instead of /usr/share/doc/$mainpkg-doc/   care to move them?
* question: why don't you also sort the (build-)deps?


>     % dgit sbuild || dgit gbp-build --git-pbuilder
>     # ^ no source-only uploads to binNEW!

I use pbuilder, so I can't use `dgit sbuild`.
I also don't use gbp to build my package, but I usually `debuild -S`
them, then `cd ..` and `pbuilder b foo_123.dsc`, and depending on
whether I'm doing a source-only upload or a source+binary upload I
either upload that one foo_123_source.changes  that debuild generated,
or the ~/pbuilder/results/sid/amd64/foo_123_amd64.changes that pbuilder
built (note how it's in a completely different directory).

Now, I understand I shouldn't run debuild directly on this but:
    % dgit build-source
wants all the build-dependencies installed => no going to happen

digging through the manpage I ended up with
    % dgit -wg build-source

cool, I have a .dsc now.
I can build it!

but:
tests/test_main.py FFFFFFFFFFFFFFFFFFFFFFFFFFssFF.FFF.FFFFFFFFFFF.FFFF.FF.F.FFFFFFFF..FFFFFFFF

They are all like

tests/test_main.py:131: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

input_basename = 'ccitt.pdf', output_basename = 'test_quick.pdf'
env = {'CCACHEDIR': '/home/mattia/pbuilder/cache/ccache', 'CCACHE_DIR': '/home/mattia/pbuilder/cache/ccache', 'CCACHE_PATH': '/usr/bin', 'CCACHE_UMASK': '000', ...}
args = (), input_file = '/build/ocrmypdf-4.3/tests/resources/ccitt.pdf'
output_file = '/build/ocrmypdf-4.3/tests/output/main/test_quick.pdf'

    def check_ocrmypdf(input_basename, output_basename, *args, env=None):
        "Run ocrmypdf and confirmed that a valid file was created"
        input_file = _infile(input_basename)
        output_file = _outfile(output_basename)
    
        p, out, err = run_ocrmypdf(input_basename, output_basename, *args, env=env)
        if p.returncode != 0:
            print('stdout\n======')
            print(out)
            print('stderr\n======')
            print(err)
>       assert p.returncode == 0
E       assert 15 == 0
E        +  where 15 = <subprocess.Popen object at 0x7f1dc9a8ed30>.returncode

tests/test_main.py:68: AssertionError
----------------------------- Captured stdout call -----------------------------
stdout
======

stderr
======
  ERROR - [Errno 13] Permission denied


Is there some caveat I don't know?



Then, once I build this, should I e.g. place the built files (I suppose
I have to do a -b build, right, not -F?) in .. realtative to the
unpacked source tree and just dgit push?

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature


Reply to: