[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#841065: RFS: gnome-shell-extensions-dashtodock/55-1, ITP: 829185 -- dash-to-dock extension for GNOME shell



Control: owner -1 !
Control: tags -1 moreinfo

Hallo highvoltage,

Can you check if you think those comments are valid? 

- the patch for the installation directory should be upstreamed,
(I had something similar for one of my extensions, I solved it this
way:)
https://github.com/laserb/gnome-shell-extension-suspend-button/pull/19

- I guess the README should also not installed to /usr/share/gnome-
shell/extensions/dash-to.../ but /usr/share/doc/gnome-shell-extensions-
dashtodock (probably an extra "docs" in the filename of debian/gnome-
shell-extension-dashtodock-docs.docs)

- you're shipping in the debian.tar an autoreconf.(before|after)..
Probably stray files

- maybe also a versioned dependency on gnome-shell >=3.18 won't hurt
here as well to avoid issues when (partially) upgrading from jessie
 
- translators copyright should be also recorded in d/copyright.

Thanks!

--
tobi


Reply to: