[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#834539: RFS: zuki-themes/3.20-1-1 [ITP]



control: tag -1 +moreinfo
control: owner -1 !

Dear James,

To help you get things moving with this RFS, here are some suggestions:

1) Your Vcs-Git repository seems to be out of sync with the tarball you
uploaded to mentors:

    hephaestus ~/rfs/zuki-themes % sbuild --no-clean-source
    dpkg-source: info: using source format '3.0 (quilt)'
    dpkg-source: info: building zuki-themes using existing
    ./zuki-themes_3.20-1.orig.tar.gz
    dpkg-source: error: cannot represent change to zukitre.png: binary file
    contents changed
    dpkg-source: error: add zukitre.png in debian/source/include-binaries if
    you want to store the modified binary in the debian tarball
    dpkg-source: error: cannot represent change to zukitwo.png: binary file
    contents changed
    dpkg-source: error: add zukitwo.png in debian/source/include-binaries if
    you want to store the modified binary in the debian tarball

(the orig I'm using is from mentors, the dir is your git repo)

2) It would be best to patch README.md to remove installation and
compatibility information.  Someone reading the file will already have
the package installed, and you should keep the package compatible with
whatever version of GNOME currently in Debian, so it could confuse
someone to see that information.

If you are able to address these issues, I will write a more in-depth
review.

Thanks!

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: