[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#838870: RFS: nbsphinx/0.2.9+ds-1 [ITP] -- Jupyter Notebook Tools for Sphinx



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hello Frederic, thanks for your review,



On 03/10/16 14:55, Frederic Bonnard wrote:
> 
> Hi Jerome,
> 
> - d/control :
>   * could you sort de dependencies : wrap-and-sort can help

done

>   * by using github source tarball, you wouldn't have to deal with
>     suffix and get-orig-source stuff : nbsphinx.egg-info and setup.cfg are
>     already stripped

I am more comfortable to stay with grabbing from https://pypi.debian.net


> - d/copyright : "There are many versions of the MIT license. Please use Expat
>   instead, when it matches."
>   https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

done


> - d/rules :
>   * could you use $(CURDIR) instead of relative paths ?

indeed it is a better idea: I will keep it in mind to propagate it in my other pacakges

>   * about mathjax workaround, will the generation embeds the js or will it link
>     to the local mathjax package in python-nbsphinx-doc ? meaning, do you
>     confirm you don't need python-nbsphinx-doc to Depends on libjs-mathjax
>     ? Sorry I could not build and check that to verify by myself :)

I pick the workaround suggested in the bugreport

	https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=739300

which deals with this issue. Meanwhile I added libjs-mathjax in the Depends field.



> - d/patches : "debian" is not a keyword listed in DEP3 for "Origin". I guess it
>     would rather be "vendor" but as you provide "Author" already, "Origin" is
>     not required.

Good point. As I do not like the idea of dropping out Debian, I pursue http://sources.debian.net/ :
let add vendor and keep Debian:
Origin: vendor, Debian


> 
> When I wanted to test the build, I couln'd find the following packages
> : python[3]-nbconvert python[3]-nbformat python[3]-jupyter-client
> python[3]-ipykernel Do you have the links to the .dsc files so that I can go
> further ?

In experimental. Nevertheless, I used the following apt_preferences(5) material:

- --8><-------------------------------------------------------
Package: python-ipython-genutils python3-ipython-genutils
Pin: version 0.*
Pin: release a=unstable
Pin-Priority: 1523

Package: /ipython/
Pin: version 2.*
Pin: release a=unstable
Pin-Priority: -10

Package: /ipython/
Pin: version 5.*
Pin: release a=experimental
Pin-Priority: 1511
- -----------------------------------------------------><8-----

Thanks,
Jerome




> Thanks!
> 
> F.
> 
> On Sun, 25 Sep 2016 22:40:29 +0100, Jerome Benoit <calculus@rezozer.net> wrote:
>> Package: sponsorship-requests
>> Severity: wishlist
>>
>> Dear Sponsors,
>>
>> 	I am looking for sponsorship for the Debian package nbsphinx [0,1].
>> 	This package brings nbsphinx to Debian on behalf of the Debian
>> 	Python Modules Team. This is my second Debian Python Module package,
>> 	so it might certainly be subject to some mistakes.
>>
>> Thanks in advance,
>> Jerome
>>
>> [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=838806
>> [1] https://anonscm.debian.org/git/python-modules/packages/nbsphinx.git
>>
>> -- System Information:
>> Debian Release: Jessie*
>>   APT prefers stable
>>   APT policy: (990, 'stable'), (500, 'stable-updates')
>> Architecture: amd64 (x86_64)
>> Foreign Architectures: i386
>>
>> Kernel: Linux 3.16.7-ckt20-0001-mbp62 (SMP w/4 CPU cores)
>> Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
>> Shell: /bin/sh linked to /bin/dash
>> Init: sysvinit (via /sbin/init)
>>
> 

- -- 
Jerome BENOIT | calculus+at-rezozer^dot*net
https://qa.debian.org/developer.php?login=calculus@rezozer.net
AE28 AE15 710D FF1D 87E5  A762 3F92 19A6 7F36 C68B
-----BEGIN PGP SIGNATURE-----

iQQcBAEBCgAGBQJX8u0MAAoJED+SGaZ/NsaLLHkgANOyccVxzYeE9hNVjDmRm/bh
IUmc9vqnizKxB7H4452A6slkNcfJ5MsM27XsSe6yba05JLHHZgzbpIeRbPR+4mi3
XzzSv/945Xf3jfpBGIoETTrnyoxTMwaFuo4SvTYtNl0jsyKSo77eTUxIKIqIvf22
w0X4jK2aVUvsoqKw4rkQUQ2vztzBIGeUiA6VNYLWk7xW5QlSRyMxIU5IR9OAjP83
gbh03EUsiNdPKxrA9DE4gHalnoSnqgSETWzw+0H1YbWzGShW8h44ENuVhM8T70eS
+/ea5KYgzg3DLJ+OBmfmWz+vWYEtkZmgZyC0izIRna7VXhnzvXl/B1ngWgmB7QZz
DrAGPBq6P9NVGY9q+r+4qV2n1wV4bm6afVlb90GFmnZL/41coU6bnCneJ8QuVIIM
YU9vEg3xye6IHxCAnRYv6YluOy8K6oYU+ll8a0hJMoK33uC/X0HA2fRR0evYH60B
cLuJJi5uvlSDIDFN5klAh/B3/knvQvaAVmWi/KduZg2czf71yVys9GltETPhimc0
iPFlUTTptoEDNDbBrsffPVsfV8HXUWMO2/obl9EQMj/c/bTTMcz6vStJKudBGmSi
B6VE+JeaFGk+6xdStUesd0DDldg4jAan8zE4Qu486boRhte+WS/blekKaVTtGwrS
NEj9Abdq26kASG1u6pFzkStiFFjqC0Bbz+MafhM6uYoTABPeUNfTmNlnum+pIH4I
EExoBRrLfD7gsivJO6EI6ZF/btZt1xIdw4PxBHEiz2ZHPWw6BenI8i7yRVfSuiAu
EUZ3PpGzMqqxACPDMKy5dc5wgxvWN/y226tFW1Z0sunRGEkySL9QCAJRkujfkkvE
RqhJxdGK+rAdJLXTFuk1DvYdKPVObYXEOJLDrMguMgtzCHt9xOd157kC6dF8KnEx
6gTj+Fi28RF/PE5b+2+hdJPA2TOlu+dGouKMAUBruQRSO+hU+6uRi/hAMUbjZXgv
BJ4j56wrPUYnoRw9mKZv/J73y2cyfyOCFis9mIA+/e8kmpOUjcoHEv+UDxt05Whj
PhMYcdaLcyxUNNyaBK69KAkgdPGmZCEnwqQr6aUpQLAhrg49agiAYTBLlRdK+qfM
SjcmOiMRzE1S+XWAkmCaVNeRayZug4ZpIWqgRTE30SigexylzS/hBPXb25v8xZy8
tnY0lKcIlOFU5vFOEHgIGgVgpFWOfrirh4xzU8FNACsOq5VmTV9IvOFRgU02Ntzp
6bro912bZlDF4b42mSyY+0fVr14/Qq3vMqn2516184oM97wXaMq9fqdpPPgxkDUi
/yf9V1KhpjsDfWuoTAis2MRFk3BnVYrHDbK5BRAjdHOLexImgo9K8Hh7iZuDf2g=
=NjBp
-----END PGP SIGNATURE-----


Reply to: