Bug#837650: RFS: cf-python/1.3.1+dfsg.1-1 [ITP]
Hi Klaus,
>If I misbehaved I apologize. I tried to follow the pertinent Debian
>documentation, but that can be a challenge in itself.
it is good, just I like the "better safe than sorry" approach :)
(additional review, on top of Sebastiaan's one)
* Requires a python version from 2.6 up to, but not including, 3.0.
Sebastiaan, I'm not sure we can build Python3 version, but I leave this
check to the maintainer :p
>If it's preferable to keep the package in the GIS team, I will also be
>happy to do that. I am inexperienced in Debian politics and submit to
>your better judgment.
not needed, it is fine this way
review:
1)
./docs/source/ttt/cloud_sptheme/themes/redcloud/static/redcloud.css_t: * :license: BSD
./docs/source/ttt/cloud_sptheme/themes/cloud/static/jquery.cookie.js: * Dual licensed under the MIT and GPL licenses:
./docs/source/ttt/cloud_sptheme/themes/cloud/static/jquery.cookie.js: * http://www.opensource.org/licenses/mit-license.php
./docs/source/ttt/cloud_sptheme/themes/cloud/static/jquery.cookie.js: * http://www.gnu.org/licenses/gpl.html
./docs/source/ttt/cloud_sptheme/themes/cloud/static/cloud.js_t: * :license: BSD
./docs/source/ttt/cloud_sptheme/themes/cloud/static/cloud.css_t: * :license: BSD
./docs/source/ttt/cloud_sptheme/themes/cloud/layout.html: :license: BSD
missing licenses ^^
2) grep copyright . -Ri
some missing copyrights :)
3)
something about:
cf/um/umread/c-lib/Makefile
CC=gcc
such stuff is a no-go for my personal policy.
People might want to export CC=clang or whatever, and see it build with it.
Changing
CC=gcc
to CC?=gcc fixes this
(set if not already set)
the same applies to other stuff in that file.
$(LDFLAGS)<-- this should be at the end of the line, not at the begin, otherwise
you might see some libraries stripped just because the .o files needing them
are put after (this happens when wl-asneeded is used/default)
4)
Depends:
libudunits2-0,
please avoid this because it means a sourceful uploads each time that package
has a soname bump.
e.g. you can avoid that by having a dependency on the -dev package,
and for runtime... don't know, you don't link it, do you?
./cf/units.py: _udunits = ctypes.CDLL('libudunits2.so.0')
probably that is the best way, at least a sourceful upload is needed
anyway, to check if the code still works.
5)
http://debomatic-amd64.debian.net/distribution#unstable/cf-python/1.3.2+dfsg.1-1/lintian
something might be addressed, something is not worth a fix
also blhc complains
http://debomatic-amd64.debian.net/distribution#unstable/cf-python/1.3.2+dfsg.1-1/blhc
6) isn't 1.3.1+dfsg1-1 a better versioning? I don't like too much that "."
I think this is all for now :)
G.
Reply to: