Bug#838679: [Debian-science-sagemath] Fwd: Bug#838679: RFS: cysignals/1.1.1+ds-1 [ITP] -- interrupt and signal handling for Cython
Ximin Luo:
> Hey, nice work. I'm taking a look now.
>
Hey, it looks good! I couldn't spot any problems.
Just the following minor things:
(1)
d/rules:
override_dh_install-arch:
true
Could you add a comment explaining this? I didn't look in too much detail but I couldn't figure out the reason for this. I did run dpkg-buildpackage -A and -B checked they still work, so that's good. It would be good to add a comment, so future readers don't get confused.
(2)
Instead of maintaining two separate git branches, I suggest using build profiles:
https://wiki.debian.org/BuildProfileSpec
I've pushed some commits to the git repo that makes this work already, see if you like them, or revert if you don't :p
The default build will leave out the -pari stuff. To enable the pari stuff, you can either :
a. use `(dpkg-buildpackage|gbp buildpackage) -Ppkg.cysignals.pari` or
b. set DEB_BUILD_PROFILES=pkg.cysignals.pari for lower-level tools like `debian/rules`
I had to use a slight hack in debian/tests/control but I thought it was still worth it, to avoid switching between branches all the time.
If you like this, please also edit debian/README.source to describe this new workflow.
(3)
You tagged debian/1.1.1+ds-1 already in the git repo. I suggest not doing this yet, and delete the current tag - we have some newer unreleased commits anyway.
My preferred workflow is to keep UNRELEASED in d/changelog, then when everything is ready I git push, then `dch -r`, commit, build, dput and wait for the ACCEPTED email from ftp-masters. Only after I get email, do I then run `gbp buildpackage --git-tag-only` and then push this last commit plus the tag that was just created.
Sometimes (like now) there's no point using UNRELEASED if d/changelog already says something else, but the rest of the above still works.
X
--
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git
Reply to: