[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#838617: RFS: python-socketpool_0.5.3-3 [RC] -- upload or nmu

Package: sponsorship-requests
Severity: important

Hello

I'm looking for an sponsor of my updated python-socketpool package.

The update fixes a FTBFS that would make the package to be autoremoved,
python-socketpool is one of the dependencies of couchapp, which I
maintain.

I'm CC ing in this bug report both the uploader and the
maintainer team of the package.

I've attached 3 diff files to this bug report

- python-socketpool-0.5.3-3.1-nmu.diff

  diff since last upload to debian, this diff would produce an NMU.
  I don't think it will apply cleanly on top of the git repo on its current
  status. It does includes changes made by Ondřej Nový

  Changelog

  python-socketpool (0.5.3-3.1) unstable; urgency=low

    [ gustavo panizzo ]
    * Non-maintainer upload.
    * Patch setup.py to use codecs module to read unicode, Fixes FTBFS
      (Closes: #835682) (Closes: #834920).
    * Fix a typo on python3-socketpool long description

    [ Ondřej Nový ]
    * Fixed homepage (https)
    * Fixed VCS URL (https)



- python-socketpool-0.5.3-3.1-diff-git.diff

  diff against the git repo on its current status (f108336)
  this builds on top of Ondřej Nový's changes. It would produce an NMU.
  it contains the same changes as the previous patch

- python-socketpool_0.5.3-3.diff

  diff against the git repo on its current status (f108336)
  this builds on top of Ondřej Nový's changes. It would produce an
  standard upload.
  it contains the same changes as the previous patch and other fixes.

  Changelog

  python-socketpool (0.5.3-3) unstable; urgency=low

    [ gustavo panizzo ]
    * Patch setup.py to use codecs module to read unicode, Fixes FTBFS
      (Closes: #835682) (Closes: #834920).
    * Fix a typo on python3-socketpool long description
    * Increase the delhelper compat level to 9.
    * Add dh-python to build deps.
    * Bump Standards-Version to 3.9.8. No changes were needed.

    [ Ondřej Nový ]
    * Fixed homepage (https)
    * Fixed VCS URL (https)


I prefer if this gets uploaded. this build can be downloaded from -mentors or this git repo

git.debian.org:/srv/home/users/gfa-guest/public_git/python-socketpool

https://mentors.debian.net/debian/pool/main/p/python-socketpool/python-socketpool_0.5.3-3.dsc

thanks!


-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (900, 'testing'), (300, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nru python-socketpool-0.5.3/debian/changelog python-socketpool-0.5.3/debian/changelog
--- python-socketpool-0.5.3/debian/changelog	2015-11-25 22:40:35.000000000 +0800
+++ python-socketpool-0.5.3/debian/changelog	2016-09-20 18:41:35.000000000 +0800
@@ -1,3 +1,17 @@
+python-socketpool (0.5.3-3.1) unstable; urgency=low
+
+  [ gustavo panizzo ]
+  * Non-maintainer upload.
+  * Patch setup.py to use codecs module to read unicode, Fixes FTBFS
+    (Closes: #835682) (Closes: #834920).
+  * Fix a typo on python3-socketpool long description
+
+  [ Ondřej Nový ]
+  * Fixed homepage (https)
+  * Fixed VCS URL (https)
+
+ -- gustavo panizzo <gfa@zumbi.com.ar>  Tue, 20 Sep 2016 18:41:35 +0800
+
 python-socketpool (0.5.3-2) unstable; urgency=medium
 
   [ SVN-Git Migration ]
diff -Nru python-socketpool-0.5.3/debian/control python-socketpool-0.5.3/debian/control
--- python-socketpool-0.5.3/debian/control	2015-11-25 22:40:35.000000000 +0800
+++ python-socketpool-0.5.3/debian/control	2016-09-20 18:41:35.000000000 +0800
@@ -9,8 +9,8 @@
 	python-setuptools,
 	python3-setuptools
 Standards-Version: 3.9.6
-Homepage: http://pypi.python.org/pypi/socketpool
-Vcs-Git: git://anonscm.debian.org/python-modules/packages/python-socketpool.git
+Homepage: https://pypi.python.org/pypi/socketpool
+Vcs-Git: https://anonscm.debian.org/git/python-modules/packages/python-socketpool.git
 Vcs-Browser: https://anonscm.debian.org/cgit/python-modules/packages/python-socketpool.git
 
 Package: python-socketpool
@@ -31,4 +31,4 @@
  Socket pool is a simple socket pool that supports multiple factories and
  backends. It can easily be used by gevent, eventlet or any other library.
  .
- This package for Python 2.
+ This package for Python 3.
diff -Nru python-socketpool-0.5.3/debian/patches/fix-FTBFS.patch python-socketpool-0.5.3/debian/patches/fix-FTBFS.patch
--- python-socketpool-0.5.3/debian/patches/fix-FTBFS.patch	1970-01-01 08:00:00.000000000 +0800
+++ python-socketpool-0.5.3/debian/patches/fix-FTBFS.patch	2016-09-20 18:41:35.000000000 +0800
@@ -0,0 +1,20 @@
+Description: Fix a FTBFS
+ setup.py open() an unicode file as ascii, this patch modifies setup.py
+ to open the file as binary then decodes it from utf-8
+Origin: Upstream
+Author: Ralph Bean rbean@redhat.com
+Last-Update: 2016-04-06
+
+--- a/setup.py
++++ b/setup.py
+@@ -22,8 +22,8 @@ CLASSIFIERS = [
+ 
+ 
+ # read long description
+-with open(os.path.join(os.path.dirname(__file__), 'README.rst')) as f:
+-    long_description = f.read()
++with open(os.path.join(os.path.dirname(__file__), 'README.rst'), 'rb') as f:
++    long_description = f.read().decode('utf-8')
+ 
+ DATA_FILES = [
+         ('socketpool', ["LICENSE", "MANIFEST.in", "NOTICE", "README.rst",
diff -Nru python-socketpool-0.5.3/debian/patches/series python-socketpool-0.5.3/debian/patches/series
--- python-socketpool-0.5.3/debian/patches/series	1970-01-01 08:00:00.000000000 +0800
+++ python-socketpool-0.5.3/debian/patches/series	2016-09-20 18:41:35.000000000 +0800
@@ -0,0 +1 @@
+fix-FTBFS.patch

diff --git a/debian/changelog b/debian/changelog
index e8e866c..e570db5 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,9 +1,16 @@
-python-socketpool (0.5.3-3) UNRELEASED; urgency=medium
+python-socketpool (0.5.3-3.1) unstable; urgency=low
 
+  [ gustavo panizzo ]
+  * Non-maintainer upload.
+  * Patch setup.py to use codecs module to read unicode, Fixes FTBFS
+    (Closes: #835682) (Closes: #834920).
+  * Fix a typo on python3-socketpool long description
+
+  [ Ondřej Nový ]
   * Fixed homepage (https)
   * Fixed VCS URL (https)
 
- -- Ondřej Nový <novy@ondrej.org>  Tue, 29 Mar 2016 22:23:47 +0200
+ -- gustavo panizzo <gfa@zumbi.com.ar>  Tue, 20 Sep 2016 18:41:35 +0800
 
 python-socketpool (0.5.3-2) unstable; urgency=medium
 
diff --git a/debian/control b/debian/control
index 30c44cd..c76044c 100644
--- a/debian/control
+++ b/debian/control
@@ -31,4 +31,4 @@ Description: simple Python 3 socket pool
  Socket pool is a simple socket pool that supports multiple factories and
  backends. It can easily be used by gevent, eventlet or any other library.
  .
- This package for Python 2.
+ This package for Python 3.
diff --git a/debian/patches/fix-FTBFS.patch b/debian/patches/fix-FTBFS.patch
new file mode 100644
index 0000000..81a32b5
--- /dev/null
+++ b/debian/patches/fix-FTBFS.patch
@@ -0,0 +1,20 @@
+Description: Fix a FTBFS
+ setup.py open() an unicode file as ascii, this patch modifies setup.py
+ to open the file as binary then decodes it from utf-8
+Origin: Upstream
+Author: Ralph Bean rbean@redhat.com
+Last-Update: 2016-04-06
+
+--- a/setup.py
++++ b/setup.py
+@@ -22,8 +22,8 @@ CLASSIFIERS = [
+ 
+ 
+ # read long description
+-with open(os.path.join(os.path.dirname(__file__), 'README.rst')) as f:
+-    long_description = f.read()
++with open(os.path.join(os.path.dirname(__file__), 'README.rst'), 'rb') as f:
++    long_description = f.read().decode('utf-8')
+ 
+ DATA_FILES = [
+         ('socketpool', ["LICENSE", "MANIFEST.in", "NOTICE", "README.rst",
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..c41fab6
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+fix-FTBFS.patch

diff --git a/debian/changelog b/debian/changelog
index e8e866c..1a39897 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,9 +1,18 @@
-python-socketpool (0.5.3-3) UNRELEASED; urgency=medium
+python-socketpool (0.5.3-3) unstable; urgency=low
 
+  [ gustavo panizzo ]
+  * Patch setup.py to use codecs module to read unicode, Fixes FTBFS
+    (Closes: #835682) (Closes: #834920).
+  * Fix a typo on python3-socketpool long description
+  * Increase the delhelper compat level to 9.
+  * Add dh-python to build deps.
+  * Bump Standards-Version to 3.9.8. No changes were needed.
+
+  [ Ondřej Nový ]
   * Fixed homepage (https)
   * Fixed VCS URL (https)
 
- -- Ondřej Nový <novy@ondrej.org>  Tue, 29 Mar 2016 22:23:47 +0200
+ -- gustavo panizzo <gfa@zumbi.com.ar>  Tue, 20 Sep 2016 18:41:35 +0800
 
 python-socketpool (0.5.3-2) unstable; urgency=medium
 
diff --git a/debian/compat b/debian/compat
index 45a4fb7..ec63514 100644
--- a/debian/compat
+++ b/debian/compat
@@ -1 +1 @@
-8
+9
diff --git a/debian/control b/debian/control
index 30c44cd..7d208dd 100644
--- a/debian/control
+++ b/debian/control
@@ -1,21 +1,22 @@
 Source: python-socketpool
 Section: python
 Priority: extra
-Maintainer: Debian Python Modules Team <python-modules-team@lists.alioth.debian.org> 
+Maintainer: Debian Python Modules Team <python-modules-team@lists.alioth.debian.org>
 Uploaders: TANIGUCHI Takaki <takaki@debian.org>
-Build-Depends: debhelper (>= 8.0.0),
-	python-all,
-	python3-all,
-	python-setuptools,
-	python3-setuptools
-Standards-Version: 3.9.6
+Build-Depends: debhelper (>= 9.0.0),
+               dh-python,
+               python-all,
+               python-setuptools,
+               python3-all,
+               python3-setuptools
+Standards-Version: 3.9.8
 Homepage: https://pypi.python.org/pypi/socketpool
 Vcs-Git: https://anonscm.debian.org/git/python-modules/packages/python-socketpool.git
 Vcs-Browser: https://anonscm.debian.org/cgit/python-modules/packages/python-socketpool.git
 
 Package: python-socketpool
 Architecture: all
-Depends: ${python:Depends}, ${misc:Depends}
+Depends: ${misc:Depends}, ${python:Depends}
 Provides: ${python:Provides}
 Description: simple Python 2 socket pool
  Socket pool is a simple socket pool that supports multiple factories and
@@ -25,10 +26,10 @@ Description: simple Python 2 socket pool
 
 Package: python3-socketpool
 Architecture: all
-Depends: ${python3:Depends}, ${misc:Depends}
+Depends: ${misc:Depends}, ${python3:Depends}
 Provides: ${python3:Provides}
 Description: simple Python 3 socket pool
  Socket pool is a simple socket pool that supports multiple factories and
  backends. It can easily be used by gevent, eventlet or any other library.
  .
- This package for Python 2.
+ This package for Python 3.
diff --git a/debian/patches/fix-FTBFS.patch b/debian/patches/fix-FTBFS.patch
new file mode 100644
index 0000000..81a32b5
--- /dev/null
+++ b/debian/patches/fix-FTBFS.patch
@@ -0,0 +1,20 @@
+Description: Fix a FTBFS
+ setup.py open() an unicode file as ascii, this patch modifies setup.py
+ to open the file as binary then decodes it from utf-8
+Origin: Upstream
+Author: Ralph Bean rbean@redhat.com
+Last-Update: 2016-04-06
+
+--- a/setup.py
++++ b/setup.py
+@@ -22,8 +22,8 @@ CLASSIFIERS = [
+ 
+ 
+ # read long description
+-with open(os.path.join(os.path.dirname(__file__), 'README.rst')) as f:
+-    long_description = f.read()
++with open(os.path.join(os.path.dirname(__file__), 'README.rst'), 'rb') as f:
++    long_description = f.read().decode('utf-8')
+ 
+ DATA_FILES = [
+         ('socketpool', ["LICENSE", "MANIFEST.in", "NOTICE", "README.rst",
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..c41fab6
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+fix-FTBFS.patch
Reply to: