[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#837650: RFS: cf-python/1.3.1-1 [ITP]




On 14/09/2016 04:51, Ben Finney wrote:
> On Wed, 2016-09-14 11:17 +1000, Ben Finney <bignose@debian.org> wrote:
>> Here are some comments I have for improving the packaging work:
> 
> Further:
> 
> * The source package should ideally not contain non-source forms of the
> work.
> 
>   I see that there is a tree of generated documentation that is not the
>   source form.
> 
>   Instead, the generated files should be removed from the Debian source
>   file, and the documentation built from its source form at build time
>   using upstream's build procedure for that.
Done.

 
>   Similarly, any non-source forms should be removed and (if necessary)
>   replaced with their corresponding source in a re-packaged upstream
>   tarball. The Debian build should use upstream's build system for
>   generating those files from their source form, and only install that
>   result.
Are you talking about the test_file.nc? The problem is the following:
This file is supposed to be created by the first test and than to be
available for the subsequent tests. However, some of those require it
to be present not only at runtime, but at import of the module.
The way tests are run by the build system, all tests are imported before
the first test is run.

In summary, the tests should be written more robustly, and I will try
to work with upstream on that. Until that time this is a quick fix to
permit the building of a full tested package.


Thanks again for your help!

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: