[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#835975: RFS: triops/9.0-1 [ITP]



Control: tags -1 + moreinfo

* Roberto S. Galende <roberto.s.galende@gmail.com>, 2016-08-29, 18:58:
https://mentors.debian.net/debian/pool/main/t/triops/triops_9.0-1.dsc

I had only a quick look at the package, but code like this:

      // needed by createIV_v3
       srand((unsigned) time(NULL));

and

      iv->rand1=rand()*rand();

makes me think this is very immature and not suitable for Debian at this time.

Please:

1) Document the exact algorithm and file format you use.
2) Have the design and the code reviewed by a cryptography expert.
3) Write a comprehensive test suite.
4) Gain a significant user-base.

Then you can think about getting your software into Debian.

--
Jakub Wilk


Reply to: