[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#829520: RFS: mbpfan/1.9.1-1 ITP



control: tag -1 +moreinfo

Dear Herminio,

I'd like to review this package and help you get it into good shape for
an upload to Debian, but it's quite hard to review right now because the
debian/ subdir has a lot of cruft.

If you resolve the following clean-up issues, please remove the moreinfo
tag from the RFS bug, let me know and I'll review it.

1. Please make the packaging available in git, rather than a .dsc from
mentors.  This makes it easy to see when you've made suggested fixes
using `git diff`.

2. You have a lot of *.ex files that aren't doing anything in the
debian/ subdir.  And README.source.  There shouldn't be any template
files you aren't using.

3. Similarly lots of example text in d/rules.

4. And d/watch.

5. You have lots and lots of patches without proper patch headers.  The
patches seem to be revisions of each other.  You need one patch for each
meaningful change, with the reason for the change explained in the patch
header (ideally a DEP-3-compatible header).

6. You shouldn't patch the makefile's install target.  Override
dh_auto_install to disable it, and use dh_install to install the files
where they should go.  (See the manpages for those tools.)

Hope we can make progress with this one!  Thanks!

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: