[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#828157: RFS: lua-stdlib/41.2.0-1 [ITP #727169]



control: tag -1 +moreinfo

Hello Sergio,

Here's a few comments and questions on your package (hopefully get the
ball rolling on sponsorship).

Important:

1. You have Vcs-* fields but they point to someone else's debianisation.
I don't think you should add those fields until after that git repo
actually contains your version of the package.  Is there some reason you
don't want to use that other debianisation, btw?

2. I think you should run dh_autoreconf to regenerate Makefile.in and
configure.  This ensures that they can be correctly regenerated, such
that Debian is shipping the actual source code of the build system that
can be used to regenerate that build system.

3. You need to state explicit copyright for the GNU autotools files
(INSTALL, Makefile.in) which are under the FSF's special autotools
unlimited redistribution license (even if you run autoreconf they're
still present in the source package.)

Suggestions:

1. The -dev package only installs documentation.  Are you expecting it
to install something else in a future version?  Otherwise, why not use a
-doc suffix?  -dev makes people think they're getting headers etc.

2. In the description, maybe s/for common programming tasks/for common
programming tasks in the Lua programming language/g.  Makes it more
accessible for people who don't know that the 'lua-' in the name refers
to a programming language.

3. You're installing ChangeLog as the upstream changelog but that file
is akin to a git commit history.  I suggest installing NEWS as
/usr/share/doc/lua-stdlib/changelog instead (just override
dh_installchangelogs in d/rules).

4. I don't know any lua so might want to get someone from the lua team
to check your dh-lua usage, if you haven't already.

5. You could use the --linkdoc option of dh_installdocs so that the -dev
package installs the docs to /usr/share/doc/lua-stdlib.  Easier for
users to find.

6. It would be nice to install AUTHORS to properly credit the people
who have worked on this software.

HTH!

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: