[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#834262: RFS: pdfrw/0.2-3 [QA] -- PDF file manipulation library



Hi Sean,

Quoting Sean Whitton (2016-08-13 23:30:54)
> Changes since the last upload:
> 
>   * QA upload.
>   * Drop "Conflicts:/Provides:/Replaces: pdfrw" lines (Closes: #814289).
>     The pdfrw binary package is long gone and was never part of a release.
>     This fixes co-installing python-pdfrw and python3-pdfrw, and other
>     package combinations.
>     Thanks to Aaron M. Ucko and Yuri D'Elia for useful information.
>   * d/copyright improvements:
>     - Add proper DEP-5 header
>     - Correct licence name MIT -> Expat
>     - Factor out Expat license text into its own paragraph
>     - Update copyright years for Patrick Maupin
>     - Add missing copyrights of Attila Tajti, Narijus Mika & Mathieu Fenniak
>       See LICENSE.txt in upstream source.
>   * Fix Vcs-* URIs.
>     They were previously pointing at the dgit repo for src:botch.

whoops! I have *no idea* who could've made this mistake! :D

>   * Declare compliance with Policy 3.9.8 (no changes required).
>   * Drop duplicate build-dependency on python-setuptools.
>   * Run wrap-and-sort -abst

Thanks, I did not know of wrap-and-sort. It looks useful!

> Since this package already has history on the dgit git server, I would
> like to request that the package be sponsored using dgit (non-DDs cannot
> push the history there).  To do that:
> 
>     dgit clone pdfrw
>     cd pdfrw
>     git remote add -f spwhitton https://git.spwhitton.name/pdfrw
>     git merge --ff-only spwhitton/master

This failed.

Instead, I rebased your branch on top of dgit/sid (which worked without
conflicts) and then rebased dgit/sid on top of your branch.

>     git log -1
>     # ^ confirm that commit hash is d715f1ef184907956865d94be4f14648bb279342

The latest commit hash in dgit/sid is now obviously different due to the rebase
but I confirmed it to be the right hash in your branch.

>     # now perform all your pre-upload tests, builds etc., and then:
>     dgit build-source
>     dgit push

The last command is missing a -k. Otherwise it will fail because gpg cannot
find your private key on my system. ;)

Thanks a lot for your work!

Your changes all look good and thus I built, tested and uploaded the package
unstable.

Thanks!

cheers, josch

Attachment: signature.asc
Description: signature


Reply to: