[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#833621: RFS: libgap-sage/4.8.3+ds-1 [ITP] -- GAP kernel as a C shared library



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi Mattia, thanks for reviewing.

On 09/08/16 09:36, Mattia Rizzolo wrote:
> control: tag -1 moreinfo
> control: owner -1 !
> 
> On Sun, Aug 07, 2016 at 02:49:38AM +0100, Jerome Benoit wrote:
>> [1] https://anonscm.debian.org/cgit/debian-science/packages/libgap-sage.git
> 
> d/*.lintian-overrides + d/*.README.Debian:
>  you use the word 'furnished', which really means "providing
>  forniture" (or "provided with forniture"), afaik.  I'm positive Debian
>  doesn't ship forniture :D
>  I think you meant 'provided' there.

it is also a synonym for provide (as in French): whatever I replaced it.

> debian/adhoc/doc/libGAP.pdf:
>  you provide that pdf, which is bad:
>  pdf are not considered sources (of course), you'd need to have the
>  sources near it, and possibly build it during the build process. PDFs
>  are also listed in the REJECT-FAQ; that said, I saw pdf in the archive
>  before, and I personally don't have hard feeling towards them, so if
>  you want I can try to upload it nonetheless.

I added a d/README.source file that explains why it might be provide.

> upstream-autotoolization-test-systemwide.patch + upstream-autotoolization-header_folder.patch
>  s/hardden/harden/ (in the description)

corrected

> debianization.patch:
>  i think these kind of patches like 'Forwarded: not-needed'

added

> debianization-pkgconfig.patch
>  s/surch/such/ (in the description)

corrected

> d/copyright:
>  i see several files in src/ with this header:
>      *Y  Copyright (C)  1996,  Lehrstuhl D für Mathematik,  RWTH Aachen, Germany
>      *Y  (C) 1998 School Math and Comp. Sci., University of St Andrews, Scotland
>      *Y  Copyright (C) 2002 The GAP Group
>  those are not rapressented in your copyright.
>
These files are in fact generated file: see the added a Comment in the d/copyright.
If the issue persists, they may be re-generated on fly.
 
> 
> That said, your work is as usual outstanding :)

Apparently some effort is still needed.

Please can you review, and eventually upload, the lasted deposit.

Thanks in advance,
Jerome

> 

- -- 
Jerome BENOIT | calculus+at-rezozer^dot*net
https://qa.debian.org/developer.php?login=calculus@rezozer.net
AE28 AE15 710D FF1D 87E5  A762 3F92 19A6 7F36 C68B
-----BEGIN PGP SIGNATURE-----

iQQcBAEBCgAGBQJXqby3AAoJED+SGaZ/NsaLC0QgANPrNW87uCKUbmfueeI/erl1
mSpFKQgEl6C9KZwhmJ/jQky/YgV/E++yQxhEwg5O5BJjJq1jzsTxUG/v6VDvoXiG
D2UNnksHo4+dKNMzAgbeEXXLhA5C1Dr3TBsbzDZth8QqyheoUNMaUaKqLamDYPnc
Y3Pwb7XxyRwllIxO1lAgyniOLpZ/iOqDY9pG0AT/UAyNzzkIszpH2td/aV9BHUzv
Z9ZA19n6NcScr7K3nQXKLcs1rfsNCesFm+t3Rutce4Z3sF2h6Yb/Z5uH+ryiZJsl
opudp+L8DFYbZjt352em/PpgUMG84FqBhfHDxI+dPu7zbe4AfMMabeseqLnApRhU
YeRU8GpyA06d0zFaBU2EfIITkDC/lT2aXe4+nyP4InSpBURLhB5L4ksQ3fdKkuLV
TRv9mrpeziW/Mm5gW3zB5IVwpKDSf2ZW/cxduEPT9pq8cKKizGQn6d4mCioQMNQc
fxl11PdVj8uUPj1lMhtVPkyOVFlCIk/rXilR13RwJqijThz6TD217GJkKRVs0/B4
Jf0m+upVD1p2D1UsGN2o5J+PJL+gM0Kx9BJXvNt/ALELHp/Ce1uOvL/h6To2JExk
EshYV+is01fxWUlWi9FkBAPkhak8F64kpTcr4S6HDVSYp5mm0e1zXErqpHmVobmn
mK7yrGuxXStUJFpz53TGia816eQMYSd6TvCECtUAcd9KGS7ulH8aM9yoo49hh3ty
H3LLRPaZ7D4+mNtvEeApvpSdyqGpA5MxBAP3kPwbkfVQDxVW5qqqhADWshzUDKkQ
gLuSKzHsERo0DzNjsCOvW+RiQkK+Uh9bHgBNnNlk6NG295M3Jh9032zliLedMKIZ
adljFVshkLRVTTvgcUq/+WkxV6s8G6WXSo74K2LQ3tG52dRjwrIMze7j6NXMMwfB
wtYGlvbUwpU7spbxl1Z6Cj+FJFIRU3Y2vTy+xMJHG/cXS8hZ/93HG9aAF+VcgYs1
0F9m0IeRI6sCvRrAUo+BEGjeb+t1xIhjhi4e4OylLTR5WpUZdQ+zeaZAHFlYxdld
UR1QY8HF4oTV2SpRYUXcWWnC9bT//AG/MZGwZMVUb9O3KkhDyQbtZnki6fj7KtjN
nxe6FMdtlD161+65tfu4F5rSvPAdguTlROQcvIzjcqQqQTh70bymE+2hj/3++Wj+
XDm5oShpGt/kYCzntuQSCr4h8txpzh2Qs1zFPOCaKoiEMOfikrD324FneiZbC6qa
HuWKhycqSzCF/9BR0PWwaqNmvTQZ7pf586Djq3ewDh39FLI4ZH1egbV9bDkYqKvD
4PtpaN5oi8TQidLasHH/WmGq6X3vO8foLQTVMcrELxqXwjHkr+m79doUMyhMTvY=
=N7MM
-----END PGP SIGNATURE-----


Reply to: