On Tue, 26 Jul 2016 18:18:51 +0000 (UTC) Gianfranco Costamagna <locutusofborg@debian.org> wrote: > lets see. > 1) > > The package will be probably orphaned in 10-15 days, so you might want to set yourself > as Maintainer and adopt it > > 2) > +* Copyright (C) 2013-2015 Fulvio Benini > > > maybe you want also to put copyright file in machine readable format > https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ > Done. > 3) > X: scid source: maybe-not-arch-all-binnmuable scid -> scid-data > > 4) the breaks+replaces can be dropped, since that version is already available in oldstable > > Breaks: scid (<=1:4.3.0.cvs20110714-2) > Replaces: scid (<=1:4.3.0.cvs20110714-2) > Recommends: scid (>=1:4.3.0.cvs20111216-1) > Dropped. > last thing: > > 4) this hack seems useless now > sed s/x86_64-linux-gnu/$(DEB_HOST_MULTIARCH)/ configure > configure.sed > chmod 755 configure.sed > ./configure.sed BINDIR="$(CURDIR)/debian/tmp/scid/usr/games" \ Deleted too. > > please fix the above and I'll give another review/upload. > > thanks, > > G. Hi Gianfranco, Sorry for this late replay, I've been working on your advices and meanwhile packaging a new released version (4.6.4). You'll see in this new version I had to repack upstream sources to make the package DFSG compliant. Oliver did it with a script (prep.sh); I've used uscan and excluding files in debian/copyright (hope it's correct). It's uploaded to mentors[0]. Thanks and regards, P.D: On mentors, the watch file seems that doesn't work but on my devel machine is working properly ?? [0]https://mentors.debian.net/package/scid
Attachment:
pgpRuLbm7Dpve.pgp
Description: PGP signature