[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#830569: RFS: z3/4.4.1-0.1 [NMU] [4xRC]



Hi (please cc the bug)


>I removed it, but does it do any harm?


no, I guess not
>Might have something to do with -fPIE vs. -fPIC, but one would have to
>investigate further to be sure. This is definitely not a regression,
>though, since the z3 version currently in the archive has no hardening
>flags enabled, either.

you are building a library, so I think you should use PIC for library, and PIE for
binary.


>I have reuploaded the fixed version to Mentors:
seems better, but e.g. it lacks of breaks+replaces, because you moved files between
the dev package and the new shiny one you introduced
https://wiki.debian.org/PackageTransition

at least I would expect to forward upstream failing tests


--- z3-4.4.0/examples/python/hamiltonian/hamiltonian.py 2015-06-17 21:48:28.000000000 +0200
+++ z3-4.4.1/examples/python/hamiltonian/hamiltonian.py 2016-07-10 00:23:47.000000000 +0200
@@ -1,5 +1,5 @@
############################################
-# Copyright (c) 2012 Ganesh Gopalakrishnan ganesh@cs.utah.edu
+# Copyright (c) Microsoft Corporation. All Rights Reserved. 


please fix debian/copyright


other stuff LGTM

G.


Reply to: