[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#829151: RFS: setcolortemperature/1.1-1 ITP



control: owner -1 !
control: tags -1 moreinfo
>Thanks for all your help reviewing my package!


the package is quite simple, but I would appreciate something more
verbose when calling it with wrong parameters.
e.g.
sct
sct -h
sct -v
sct 10
sudo sct 10
sudo sct 14

all gives no output.

After reading the manpage I discovered that numbers should be within a range.

I would appreciate a little help, and some error messages when bad input is provided.



other issues:
$(CC) sct.c $(CFLAGS) $(LDFLAGS) -Wall -lX11 -lXrandr -o sct


missing CPPFLAGS

LDFLAGS should go at the bottom, to avoid link failures with wl,asneeded
(e.g. on Ubuntu where it is the default)

there is a missing license in the tarball, please ask upstream to provide one

other stuff LGTM

G.


Reply to: