Bug#822613: RFS: dynamic-graph/3.0.0-1

[Gianfranco Costamagna <locutusofborg@debian.org>]

control: tags -1 moreinfo
control: owner -1 !

Hi,
lets see

>found information on 
>https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=736360 which seems to 
>suggest the problem was still contentious two years ago. Should I keep 
>overriding this warning?

I suggest to leave things as is

1) apt install check-all-the-things

codespell --quiet-level=3


^^ something that you might want to fix or report/ask upstream


2) grep copyright  . -Ri

many missing people

License: I know the license text can be just a link to common-licenses, but I still prefer
some brief explanation

https://codesearch.debian.net/results/License%3A%20LGPL-3/page_0

"the License, or (at your option) any later version."

3) missing a +, it seems an LGPL-3+ license


I like something like this


License: LGPL-3+
This package is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 3 of the License, or (at your option) any later version.
.
This package is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
Lesser General Public License for more details.
.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
.
On Debian systems, the complete text of the GNU Lesser General
Public License can be found in "/usr/share/common-licenses/LGPL-3".



4) symbols mismatches:
http://debomatic-amd64.debian.net/distribution#unstable/dynamic-graph/3.0.0-1/buildlog

http://debomatic-i386.debian.net/distribution#unstable/dynamic-graph/3.0.0-1/buildlog

and I expect some more breakages on arm* and other Debian architectures.

5) trigger:
activate-noawait ldconfig


why?


6)
>override_dh_makeshlibs:
>dh_makeshlibs --exclude=lib/plugin --noscripts
>
>override_dh_shlibdeps:
>dh_shlibdeps --exclude=lib/plugin


why?

7)

>override_dh_auto_configure:
>dh_auto_configure -- -DGENERATE_DOC=ON

this won't work, because arch=all is a builder, while arch:any are other machines.

So this probably breaks source only upload

8)

please check dpkg-buildpackage -A
and dpkg-buildpackage -B
if they run cleanly
(in clean pbuilder/sbuild unstable environments)

https://sources.debian.net/src/websocketpp/0.7.0-5/debian/rules/

this might give you some hints about the source only stuff

it should be all for now


Gianfranco