Bug#829286: RFS: newlisp/10.7.0-2

[Gianfranco Costamagna <locutusofborg@debian.org>]

control: tags -1 moreinfo


>I'd like to get a few changes I've made to newlisp uploaded.  They

>basically fix two bugs: 828805 and 828806.
>
>The changes are:
>
>- Support GNU/kFreeBSD builds (by creating the necessary makefiles and
>  adjusting source files accordingly), and
>
>- Do not use -m32/-m64 when building.
>
>I have also updated the Vcs-* links in order to reflect the use of
>collab-maint instead of my personal git server.
>
>I'm Cc'ing Andrey Rahmatullin on this message because he is the DD who
>sponsored the package first, so I believe I should give him "precedence"
>(also because I'd like to get DM rights on newlisp, so it's easier if I
>work with just one person).


sure, I won't upload it, unless Andrey asks me.

I have just a few notes, from a quick review:

1) + libncurses5-dev


why?


please explain the additional build dependency in changelog!

2)
did you remove the -m32 and -m64 with some special sed command?

I ask, because you also patched some binaries in the source tree, and
I'm mostly sure this isn't what you have to do:
+diff --git a/qa-specific-tests/ffitest.dylib b/qa-specific-tests/ffitest.dylib
+index 3017a91..4e0eb2e 100755
+--- a/qa-specific-tests/ffitest.dylib
++++ b/qa-specific-tests/ffitest.dylib


this, IIRC is some OSX special file, so I guess you better remove that file
from the patch, since it is introducing really useless stuff.

also, you have an ~1k LOC patch, where probably you would just need to patch
two or three places
(but if you got this patch upstream accepted I would leave it as-is)

Otherwise I would avoid patching places such as
+-            (compile-recover "gcc -m32 ../util/ffitest.c -shared -o ffitest.dylib")
+-            (compile-recover "gcc -m64 ../util/ffitest.c -shared -o ffitest.dylib"))


makefile_sunos*
makefile_opensolaris*
makefile_netbsd*

and so on

As a personal opinion, I would patch all of them only after getting them accepted
upstream, and in case they don't care about this, just patch the minimum set of files/makefiles
used in Debian/Linux/kFreeBSD builds.

Otherwise a 1k lines patch will be probably a nightmare to maintain/rebase on new releases.

Just my .02$, of course I tagged moreinfo, but Andrey might have a different opinion...

cheers!

Gianfranco