[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#828166: RFS: speedcrunch/0.11-1 [ITA]



Thanks for the reviews!

On Mon, 27 Jun 2016 at 15:23 Gianfranco Costamagna <locutusofborg@debian.org> wrote:
please try to be more verbose in changelog:
>bump std-version (maybe extract in a new changelog entry)


copyright in machine readable format
 
I'm not sure what you mean by that? But I extended the changelog somewhat.

I must say I'm a bit confused about how the Developer Reference suggests to "concentrate on describing significant and user-visible changes," but the informal advice I've heard on changelog entries was always to be very detailed and granular, which to me seems more like a job for VCS history than a changelog.

d/p/0001: did you forward it upstream?

That was backported from upstream, so not necessary. I added an Origin header field to the patch to make that explicit (also changed to a more concise file name).
 

>override_dh_auto_clean:
> dh_auto_clean
> rm -f speedcrunch.1 speedcrunch.xpm


I usually like more


echo -e "speedcrunch.1\nspeedcrunch.xpm" > debian/clean
 
other stuff LGTM!

thanks for the nice cleanup :)

also, why do you force buildsystem and builddirectory?

Originally, "why not" :) But forcing CMake prevents dh from picking up the .pro file in the same directory and using qmake. "--builddirectory" was, indeed, unnecessary.
 
and last thing:
BLD_VERBOSE=1

please export it, we have tools (blhc) scanning build logs for missing flags,
so please make the build verbose (I don't care about DH_VERBOSE)

Good point, I changed it.

(I'm assuming that uploading a new package with the same version is an acceptable way to use mentors.d.n, mostly because it didn't stop me.)

Reply to: