[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#828166: RFS: speedcrunch/0.11-1 [ITA]



control: owner -1 !
control: tags -1 moreinfo
Hi,


>Thanks for adopting this package.


+1



please try to be more verbose in changelog:
>bump std-version (maybe extract in a new changelog entry)


copyright in machine readable format

d/p/0001: did you forward it upstream?

>override_dh_auto_clean:
> dh_auto_clean
> rm -f speedcrunch.1 speedcrunch.xpm


I usually like more


echo -e "speedcrunch.1\nspeedcrunch.xpm" > debian/clean

other stuff LGTM!

thanks for the nice cleanup :)

also, why do you force buildsystem and builddirectory?


and last thing:
BLD_VERBOSE=1

please export it, we have tools (blhc) scanning build logs for missing flags,
so please make the build verbose (I don't care about DH_VERBOSE)

thanks Sergio for the good review!


G.


Reply to: