--- Begin Message ---
- To: "Jason J. Herne" <hernejj@gmail.com>, "816396-done@bugs.debian.org" <816396-done@bugs.debian.org>
- Subject: Re: Bug#816396: RFS: vizigrep/1.3-1 ITP
- From: Gianfranco Costamagna <locutusofborg@debian.org>
- Date: Mon, 27 Jun 2016 12:32:03 +0000 (UTC)
- Message-id: <552780687.3496352.1467030723841.JavaMail.yahoo@mail.yahoo.com>
- Reply-to: Gianfranco Costamagna <locutusofborg@debian.org>
- In-reply-to: <CAJiM5SZr+4VrPR2516beBRsc2_M0cA==AMyXahkvcgO3khKHjQ@mail.gmail.com>
- References: <CAJiM5SbM1ZyWkzKggNpVW2Fdt5swPWcQN=P+XjG--COwVV+SPw@mail.gmail.com> <132090445.5600586.1459886987489.JavaMail.yahoo@mail.yahoo.com> <CAJiM5SaGH9YMtxw7Gvw4CcMEsCDCBEsZr9vE4tWvh_1q=11SKw@mail.gmail.com> <716403218.10782387.1466442575784.JavaMail.yahoo@mail.yahoo.com> <CAJiM5SZr+4VrPR2516beBRsc2_M0cA==AMyXahkvcgO3khKHjQ@mail.gmail.com>
Hi,
changed std-version to 3.9.8, and sponsored on deferred/5 :)
G.
Il Sabato 25 Giugno 2016 13:40, Jason J. Herne <hernejj@gmail.com> ha scritto:
Gianfranco,
I believe I have satisfied all of your packaging review comments. If you don't mind please have another look.
My latest package has been uploaded: https://mentors.debian.net/package/vizigrep
Thank you.
On Mon, Jun 20, 2016 at 1:09 PM, Gianfranco Costamagna <costamagnagianfranco@yahoo.it> wrote:
Hi,
>
>
>>You state "please use the new dh call sequencer (rules)". I'm not sure what this means exactly. Is there something missing in my rules file?
>
>
>https://sources.debian.net/src/knockpy/3.0.0-1/debian/rules/
>
>the default call should be good enough for most stuff
>
>
>#!/usr/bin/make -f
>
>%:
> dh $@
>
>
>
>in case, just override the specific call
>override_dh_foo:
> do-your-stuff
> dh_foo
>
>
>>licensecheck is complaining about unit test data. I assume I can ignore this? Or should I change my data and test?
>
>no, as long as the license is listed in debian/copyright
>
>>I assume "check-all-the-things" just runs all of the stuff you've listed below it? (flawfinder, pep8, pyflakes). Also, I assume that coding style is decided by the >author and not a reason to reject a package?
>
>
>exactly, this is something that is not strictly needed.
>apt-get install -t experimental check-all-the-things
>>Thanks again for your time.
>
>
>you are welcome,
>
>G.
>
>
>
>On Tue, Apr 5, 2016 at 4:09 PM, Gianfranco Costamagna <costamagnagianfranco@yahoo.it> wrote:
>
>control: owner -1 !
>>control: tags -1 moreinfo
>>
>>hi, lets review:
>>
>>please use the new dh call sequencer (rules)
>>std-version is 3.9.7
>>no need probably to force python as runtime dependency
>>having a setup.py might be better
>>
>>check-all-the-things
>>
>>$ find -type f -iname '*.desktop' -exec desktop-file-validate {} \;
>>
>>$ licensecheck --check=. --recursive --copyright . | grep -F 'with incorrect FSF address'
>>./ut/test-data/c-source/xpad.c: GPL (v2 or later) (with incorrect FSF address)
>>
>>$ flawfinder -Q -c .
>>
>>$ pep8 --ignore W191 .
>>
>>$ pyflakes3 .
>>
>>$ pyflakes.
>>
>>
>>debian/dirs, please remove and install -d in Makefile.
>>
>>the other stuff LGTM, even if I didn't run lintian and test the package yet.
>>
>>cheers,
>>
>>G.
>>
>>Il Martedì 1 Marzo 2016 15:33, Jason J. Herne <hernejj@gmail.com> ha scritto:
>>
>>
>>
>>Package: sponsorship-requests
>>Severity: wishlist Dear mentors, I am looking for a sponsor for my package "vizigrep" * Package name : vizigrep Version : 1.3-1 Upstream Author : Jason J. Herne <hernejj@gmail.com>
>>* URL : https://github.com/hernejj/vizigrep * License : GPL Section : utils It builds those binary packages: vizigrep - graphical file contents search tool using regular expressions To access further information about this package, please visit the following URL: http://mentors.debian.net/package/vizigrep Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/v/vizigrep/vizigrep_1.3-1.dsc More information about Vizigrep can be obtained from https://github.com/hernejj/vizigrep. Changes since the last upload: * Initial Upload of Vizigrep v1.3 Regards, Jason J. Herne
>>
>
>
>--
>
>- Jason J. Herne (hernejj@gmail.com)
>
--
- Jason J. Herne (hernejj@gmail.com)
--- End Message ---