[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#827082: RFS: libredjackipset/1.1.1+20150311-1 [ITP] -- C library to store sets/maps of IP address



Hi Roger,

>Control: retitle -1 RFS: libcorkipset/1.1.1+20150311-1 [ITP] -- C
>library to store sets/maps of IP address


thanks for that!
>I think you didn't review since you did last time, and I did some
>changes based on some changes in previous post, so here I *rewrite*
>the previous post.


thanks
>Fixed.
>Fixed.


ok

>This convinced me that this library can be packaged, too.


:)
>Yes, I used python3-cram in libcork, but this time it just doesn't work.
>Without my patch, python-cram just report "no test" error.
>I guess upstream didn't finish the test case of cram.
>So I removed it.


ok


>upstream's docs/CMakeLists.txt just output nothing.
>You can see "set(MAN_PAGES)", the target is empty!


lol ok :)
>So I used the same way in libcork to generate docs.
>Actually the upstream was during the transition from sphinx to pandoc.
>They removed sphinx setting, added pandoc setting, but didn't remove
>sphinx docs.
>So I patched back sphinx setting, just works.
>
>(docs from upstream just poor, even I wrote a patch to add index page)


I was already ok with the patch, just adding some Description makes the
review easier ;)


>After reading your comment for three time, now I understand it.
>I put it under dh_install as you recommend.
>Now it's rebuildable.


:)

>Without "--builddirectory=build", the docs will be built under
><Multi-Arch>/docs/
>This make install file hard to write.
>So here I keep as it was.


mmm strange...
this is what I have in the docs file
cat debian/libcorkipset-doc.docs 
build-*/docs/html


:)

>Removed.
>Thanks for your suggestion!


wonderful! you are welcome!
>Since the most authors quit redjack, and they're almost not active,

>I consider it should be called libcorkipset.

I see activity upstream, lets wait for the rename to be effective then!
>Fixed.


ok

>> "set(CMAKE_INSTALL_LIBDIR lib${LIB_SUFFIX} CACHE STRING"
>> note the LIB_SUFFIX
>>
>> and then the install files can change from
>> usr/lib/lib*.so usr/lib/${DEB_HOST_MULTIARCH}
>> to
>> usr/lib/*/*.so
>> and similar for others
>
>Yes, moving "include(GNUInstallDirs)" makes dh-exec useless.
>My mistake forced me to introduced this complex. Sorry about that.


the missing LIB_SUFFIX makes it FTBFS on Ubuntu, where cmake has a little
different implementation.

(and a non-defined variable is just a no-op in Debian)

>Tried, just added a lintian warning.
>Should be fixed when debhelper 10 released.
>So I keep as it is.


yes, thanks!

(BTW compat 10 works great)

Gianfranco


Reply to: