[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#827529: RFS: asciiquarium/1.1-1 [ITP #823693]



Control: tags -1 + moreinfo
Control: owner -1 !

The package produces quite a lot of lintian output:

W: asciiquarium source: syntax-error-in-dep5-copyright line 11: Duplicate field files.
W: asciiquarium source: out-of-date-standards-version 3.9.6 (current is 3.9.8)
I: asciiquarium source: debian-watch-file-is-missing
W: asciiquarium: new-package-should-close-itp-bug
E: asciiquarium: copyright-contains-dh_make-todo-boilerplate
I: asciiquarium: extended-description-is-probably-too-short
W: asciiquarium: menu-command-not-in-package usr/share/menu/asciiquarium:2 usr/bin/asciiquarium

I won't repeat these problems below.


debian/patches:
- first of all, naming a patch (or any other file) just "Makefile" is
  wrong because it's not a Makefile. And patches should be named *.patch.
- but the patch is not really needed as everything it does is to add a
  working "make install" command and you can do the installation in
  debian/rules instead, by adding an override_dh_auto_install target.

debian/outfile: what is this? seems like an accidentally added file.

asciiquarium-docs.docs: what is this? you don't have a asciiquarium-docs
package.

debian/changelog: "Build for Debian unstable." is not a good first entry,
it should be "Initial package" instead (with an appropriate Closes:
addition, as reported by lintian).

debian/rules:
- it has a lot of commented dh_make boilerplate, please remove it if you
  don't need it.
- you don't need to call dh_* commands in overrides if you know they won't
  do anything

debian/copyright:
- it says "GPL-2.0" but a comment in the main program file says "either
  version 2 of the License, or (at your option) any later version."

-- 
WBR, wRAR

Attachment: signature.asc
Description: PGP signature


Reply to: