Bug#827487: RFS: circle/2.2-1 [ITP]
I had a quick look at this package too:
Vcs-Git is supposed to point to Debian packaging, not to upstream VCS.
(After you fix it, please also add Vcs-Browser.)
Where did the upstream tarball come from? There is no watch file, and
debian/copyright points to <https://github.com/circulosmeos/circle.git>,
which doesn't have a release for version 2.2.
* Adam Borowski <kilobyte@angband.pl>, 2016-06-18, 23:21:
debian/rules:
* please move flags exports before including dpkg/default.mk. The
order matters -- your version doesn't use hardening.
Or remove the include and DPKG_EXPORT_BUILDFLAGS, and let debhelper do
the job...
Also, I wonder if there's a better place for the URL than
/usr/share/doc/README.
(I hope this path is a typo...) The better place is the Homepage field;
and in fact this very URL is already there, ...
Other stuff in that file are build instructions which are irrelevant
for packaged software.
...so I'd recommend not shipping README in the binary package at this
time.
Typo in the manpage:
easy of use -> ease of use
Also, "ascii" is normally spelled "ASCII".
Please forward the manpage upstream.
<advert>
Spell-checking was brought to you by mwic:
http://jwilk.net/software/mwic
</advert>
--
Jakub Wilk
Reply to: