[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#825693: RFS: nlohmann-json/1.1.0-1 [ITP]



Control: tags -1 + moreinfo

Here are some notes about the packaging:

debian/nlohmann-json-dev.doc-base:
"Document: json" is too generic, remember it must be unique.

debian/rules:
There is too many commented out dh_make example lines, you should remove
them if you don't need them.

debian/README.source:
It says "You WILL either need to modify or delete this file"

debian/patches:
Patch names should end with .patch

debian/copyright:
It has Files-Excluded: test/catch.hpp but the tarball still contains this
file.
Consider using the same license as the upstream for debian/.
The format specification doesn't know about the License-Reference:
pseudo-field or whatever it is. Instead you should do the same as for GPL
licenses, provide a short license grant and add the path of the license
text. You can look at /usr/share/doc/*/copyright on your system for
examples.


-- 
WBR, wRAR

Attachment: signature.asc
Description: PGP signature


Reply to: