[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#816968: RFS: broadcom-facetimehd/0.0.1~git20150229.1.8cc44d6 [ITP] -- DKMS driver for Broadcom PCIe cameras



really attaching it :)

g.




Il Mercoledì 1 Giugno 2016 17:27, Gianfranco Costamagna <locutusofborg@debian.org> ha scritto:
Hi, I don't know if Nobuhiro wants to sponsor or not.

In case a little additional review:

arch: all?

I don't think it is good to try to build dkms during build.
the modules are useless anyway, and they have to be built during package
installation
(it might be good for an autopkgtestsuite).

this e.g. breaks when you run pbuilder under ubuntu, with a debian chroot and vice-versa
because the host kernel is obviously wrong and incompatible.

Please look e.g. to ktap [1] if you want to see a similar package


attached the failure log.

BTW debian gpl-3+ and upstream gpl-2+ makes impossible to forward patches without an explicit relicense.


check-all-the-things:
$ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open any of the paths given.'

$ grep -riE 'fixme|todo|hack|xxx' .

Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata

$ find -type f -iname '*.sh' -exec sh -n {} \;
$ flawfinder -Q -c .


[1]https://packages.qa.debian.org/ktap
(BTW I don't intend to sponsor until Nobuhiro says his intentions)

cheers,

G.




Il Domenica 22 Maggio 2016 22:00, Jean Baptiste Favre <debian@jbfavre.org> ha scritto:
Hello,
Sorry for long silence.

I just uploaded a new version of the package on mentors [1].
I manage to put firmware download and installation in a separate script.

Regards,
Jean Baptiste

[1]:
https://mentors.debian.net/debian/pool/main/b/broadcom-facetimehd/broadcom-facetimehd_0.0.1~git20150522.1.5a7083b.dsc


Le 07/03/2016 à 07:36, Nobuhiro Iwamatsu a écrit :
> Hi,
> 
> I reviewed your package.
> 
> debian/changelog:
>  foget colon after "closes". Please add colon.
> 
> debian/rules:
>   When you build a package, you do not download other source code and
> data from the Internet.
>   Please remove install-frwr target from debian/rules and remove
> firmware-broadcom-facetimehd package.
>   If you can remove this target, you change section from non-free to main

Attachment: broadcom-facetimehd_0.0.1~git20150522.1.5a7083b_amd64.build
Description: Binary data


Reply to: