(Note that I don't intend to sponsor this package) d/rules: - why -D_FORTIFY_SOURCE=1? Such things should be documented - commented out -Wl,--as-needed looks strange, if it doesn't work/isn't needed you shouldn't include this line at all - you can probably replace override_dh_auto_clean with debian/clean - "dh_make generated override targets" sounds strange. "This is example for Cmake (See https://bugs.debian.org/641051 )" sounds even strange, especially when looking at that bug. That commented out dh_auto_configure is strange too, especially the -DCMAKE_LIBRARY_PATH part. README.source even says "You WILL either need to modify or delete this file" d/control: - commented out Vcs-* fields should be either removed or uncommented and edited - why this package not only Conflicts but Replaces iroffer? Do you know how will apt handle this relationship? Do you intend to do anything with the iroffer package itself (it's orphaned ATM)? If you want to replace it completely then the replacing procedure is different, see https://wiki.debian.org/Renaming_a_Package d/copyright: - it says "GPL-2" and "LGPL-2.1" in the short names but "or (at your option) any later version" in the texts - using GPL for debian/ while having MIT and LGPL in the upstream source is discouraged and may cause problems if debian/ contains e.g. patches d/install is empty iroffer-dinoex.lintian-overrides: - you shouldn't override P tags - manpage-has-bad-whatis-entry override says "Upstream manpage" which doesn't sound like a valid cause to me -- WBR, wRAR
Attachment:
signature.asc
Description: PGP signature