Bug#822107: RFS: eja/9.3.12-1 [ITP]
control: owner -1 !
control: tags -1 moreinfo
eja Ubaldo!
lets the fun begin!
debian directory review:
control:
1) unsecure VCS uri
2) outdated std-version
3) wrap-and-sort please (just run the command wrap-and-sort)
4) extended description too short, and wrap to 80 column please
5) "Version" field is wrong and useless, please remove
changelog:
6) one single entry with
"Initial release: closes: #ITP_BUG"
(open an ITP bug)
7) refresh signature timestamp
8) target suite is unstable
9) *.dirs <-- remove please and install directories inside the makefile
10) copyright: is not mentioning all the copyrights, e.g. lua, some gpl2 code? and probably more
probably repack the source to exclude embedded lua, or patch the copyright file
http://metadata.ftp-master.debian.org/changelogs/main/l/lua5.2/unstable_copyright
build review:
11) custom makefile :( (just sad, with 10 lines of cmake file you can avoid all this custom stuff probably)
12) embedded lua :( (you should detect it, and use the embedded if no system lua is provided)
13) no debug -g option (please add it, and let dh_strip strip the dbg symbols)
14) I would appreciate a make install working regardless of debian or not.
(just find the lua at build time in a if statement)
"$(CC) $(CFLAGS) -o eja eja.c $(shell pkg-config --libs --cflags lua5.2) -lm $(MYLIBS)"
this is wrong in general, specially when wl-asneeded flag is the default in gcc
$(CC) $(CFLAGS) -o eja eja.c $(shell pkg-config --cflags lua5.2) -lm $(MYLIBS) $(shell pkg-config --libs lua5.2)
^^ this might work instead.
(still sad, but working)
15) install something like this?
override_dh_auto_install:
dh_auto_install -- prefix=/usr
16) (eja.h... what?)
17) missing harderning flags (google for them)
http://debomatic-amd64.debian.net/distribution#unstable/eja/9.3.12-1/blhc
18) missing watch file
19) I: eja: spelling-error-in-binary usr/bin/eja seperator separator
20) I: eja: description-synopsis-might-not-be-phrased-properly
21) I: eja: package-contains-empty-directory usr/lib/eja/
(all from http://debomatic-amd64.debian.net/distribution#unstable/eja/9.3.12-1/lintian)
(I removed the lua directory prior to run check-all-the-things)
apt-get install -t experimental check-all-the-things
$ codespell --quiet-level=3
<some>
# Parsing /proc/cpuinfo is not portable at all, use /sys instead.
$ grep -rF /proc/cpuinfo .
./lib/proc.lua: local procCpuInfo=ejaFileRead('/proc/cpuinfo')
$ luacheck -q .
<lots>
$ grep -r '/tmp/' .
$ find -type f \( -iname '*.c' -o -iname '*.cc' -o -iname '*.cxx' -o -iname '*.cpp' -o -iname '*.h' -o -iname '*.hh' -o -iname '*.hxx' -o -iname '*.hpp' \) -exec pmccabe {} + | sort -nr
<some>
test -d ./debian &&
! grep -s -q native debian/source/format &&
! test -e debian/upstream/metadata &&
echo 'Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata'
Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata
this should be enough as first review :)
please don't be scared, most of them needs some seconds of work.
Gianfranco
Il Giovedì 21 Aprile 2016 12:15, Ubaldo Porcheddu <ubaldo@eja.it> ha scritto:
Package: sponsorship-requests
Severity: normal
Dear mentors,
I am looking for a sponsor for my package "eja"
* Package name : eja
Version : 9.3.12-1
Upstream Author : Ubaldo Porcheddu
* URL : https://github.com/ubaldus/eja
* License : GPL
Section : web
It builds those binary packages:
eja - micro web server for static and dynamic Lua generated
content.
To access further information about this package, please visit the
following URL:
http://mentors.debian.net/package/eja
Alternatively, one can download the package with dget using this
command:
dget -x
http://mentors.debian.net/debian/pool/main/e/eja/eja_9.3.12-1.dsc
More information about hello can be obtained from
https://github.com/ubaldus/eja.
Regards,
Ubaldo Porcheddu
Reply to: