Bug#820383: RFS: photocollage/1.4.0-1 [ITP]
Hi Mattia,
Thanks for your remarks. I've addressed all of them, as well as
another warning output by `pbuilder --build`.
Cheers,
Adrien
2016-05-15 18:41 GMT+02:00 Mattia Rizzolo <mattia@debian.org>:
> control: tag -1 moreinfo
> control: owner -1 !
>
> On Thu, Apr 07, 2016 at 09:33:15PM +0200, Adrien Vergé wrote:
>> I am looking for a sponsor for my package "photocollage"
>
> o/
>
>> dget -x http://mentors.debian.net/debian/pool/main/p/photocollage/photocollage_1.4.0-1.dsc
>
> * d/control:
> + Vcs-* is meant to host the *debian packaging*, not whatever stuff
> upstream does. Cloning it hoping to avoid having to deal with
> tarballs and not fiding what I expected was like => -.- :)
> + Std-Version is 3.9.8 nowadays, please check against it
> * d/copyright:
> + it can't be only 2016. It's in fedora since 2015, and setup.py only
> (?) has 2013. Please be diligent when taking care of copyright
> stuff.
> + you should also consider all the people that submitted translations
> * this is 1.4.0, you already released 1.4.2, care to update?
> * `find -type f -iname '*.desktop' -exec desktop-file-validate {} \;`
> ./data/photocollage.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated
> * `find -type f \( -iname '*.po' -o -iname '*.pot' -o -iname '*.mo' -o -iname '*.gmo' \) -exec i18nspector {} +`
> has quite something to say
> * `find -type f \( -iname '*.po' -o -iname '*.pot' \) -exec msgfmt --check --check-compatibility --check-accelerators --output-file=/dev/null {} \;`
> too.
> * d/watch:
> + you used github, but apparently the tarball comes from pypi. Maybe
> you should use pypi.debian.net instead?
>
> --
> regards,
> Mattia Rizzolo
>
> GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
> more about me: https://mapreri.org : :' :
> Launchpad user: https://launchpad.net/~mapreri `. `'`
> Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Reply to: