[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#823331: RFS: node-zmq/2.15.0+dfsg-2



Hi Mattia

Thanks for taking the time to look at this.

On 15/05/16 20:42, Mattia Rizzolo wrote:
> control: tag -1 moreinfo
> control: owner -1 !
> control: block 823251 by -1
> 
> On Tue, May 03, 2016 at 05:33:28PM +0200, Gordon Ball wrote:
>>   I am looking for a sponsor for my package "node-zmq"
> 
> o/
> 
>> https://mentors.debian.net/debian/pool/main/n/node-zmq/node-zmq_2.15.0+dfsg-2.dsc
> 
> Alright, so this package is maintained in collab-maint.  Great.
> Now:
> 
> * why did you upload a -2 to mentors.d.n?

v-1 is already published in a PPA. Admittedly, it probably has fairly
few users, but still probably best not to duplicate versions. However, I
haven't uploaded 2.15.1 there so the issue shouldn't actually arise.

> * in git there is a newer version with minimal changes, guess it would
>   be better if I upload that one?

Indeed. The only changes upstream are a higher version dependency on
node-nan, which I have reflected in d/control.

> * you install History.md.  I think it would be better to install that
>   file as a changelog, see
>   https://www.debian.org/doc/debian-policy/ch-docs.html#s-changelogs
>   For that, just call dh_installchangelogs.

I've added a dh_installchangelogs entry to d/rules in git.
> 
> You don't need to upload new releases to mentors, I actually prefer
> working with git.
> 

Noted. The changelog fix should be in git master, which I think is
everything unless you've spotted something else.

Gordon


Reply to: