[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#823742: RFS: hdf-compass/0.6.0b5-1 [ITP]



Dear all,

Just as a foreword, I just wanted to point out that Andreas Tille already
sponsored the upload as is, but I asked for rejection to address further
issues.

2016-05-15 20:24 GMT+01:00 Mattia Rizzolo <mattia@debian.org>:
Again, pushing a debian/ tag before the upload is not that great idea,
as now I have things I'm not happy about and the tag needs to be
deleted/recreated.  Usually I also push the tag for teams I'm part of
(like this), but I can also leave it to you if you like.  Just that as
of now there is a tag that doesn't match reality.

* d/hdf-compass.lintian-overrides
  + bad habit doing lintian overrides without a comment.  But I can't
    imagine a reason to override binary-without-manpage.  That one just
    needs fixing, and hiding it behind an override doesn't help it.

It's an entry point to a GUI application. Not sure what the manpage is
useful for then. Please consider giving a more precise advice.

* d/rules:
  + what's the reason for disabling the tests?  please document it in a
    comment.

Test autodiscovery picks up tests whilst upstream does not officially declare
a testsuite.

Hope these pieces of explanation address your concerns.

Anyway, please consider this sponsorship on hold until further notice.

Cheers,
Ghis

Reply to: