[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system




Le 16/05/2016 15:16, Gianfranco Costamagna a écrit :
> Hi Eric,
>
>
>
>> Well autotools-dev already used. No changes here.
>> About autoreconf, I'm not familiar with it.
>> I installed it to test it. Since all seems ok, I've not removed it.
>
> https://wiki.debian.org/Autoreconf
>
> I was talking more about removing autotools-dev
I think there are too many changes in this release.
Is it okay to remove autoreconf for now,
and replace autotools-dev by autoreconf at next release ?
>
>
> 3) +Replaces: gnustep-common (<< 2.6.8-1)
>
> this is something I don't understand.
> If you upgrade gnustep make bin package with old gnustep-common installed,
> we need to replace the gnustep-config.1 manpage.
>
>
> that file is currently inside gnustep-common
>
> and you moved into gnustep-make
> https://packages.debian.org/sid/alpha/gnustep-common/filelist
Yes, the executable was in gnustep-make, thus i moved the manpage to
gnustep-make.

>
> you probably need some more keywords to ensure a good upgrade path
> https://wiki.debian.org/PackageTransition

Reorg: gnustep-common and gnustep-make existed; move one file from
gnustep-common to gnustep-make; new gnustep-common does not require new
gnustep-make
   
Breaks: gnustep-make (<<2.6.8-1)
   
Breaks: gnustep-common (<<2.6.8-1)

Is it okay to do that?

>> Yes, this is a consequence of the debian/rules rewriting.
>
> line 25, you could add something like "remove control.in file, useless now"
> or similar wording, that one was my question
OK, i m going to do that
>
>> I tested it with latest upstream version of gnustep-base, gnustep-gui
>> and and gnustep-back,
>> and all seems okay. I
>> tried it with several GNUstep related debian packages and all seems to
>> works fine.
>> I also tried to rebuild several debian gnustep packages with it and I
>> did not find any FTBFS.
>
> nice indeed, so please wait some more time, and ping me back in 7-15 days if nobody
> picked up the work in the meanwhile.

OK, I'm going to update gnustep make to do improvements you suggested.
Since I am not familiar with mentors rules, I have a question :
Should I prepare a new revision (ie 2.6.8-2) or should I update the
2.6.8-1 revision and reupload it ?

Thanks

Eric


Reply to: