control: tag -1 moreinfo
control: owner -1 !
On Mon, Apr 25, 2016 at 10:43:41PM +0200, Alberto Luaces wrote:
> I am looking for a sponsor for my package "magit-svn"
o/
> dget -x http://mentors.debian.net/debian/pool/main/m/magit-svn/magit-svn_2.1.1-1.dsc
Well, I prefer git, so I'll do the thing with git here that you (have
to?) use it, and nitpick on it.
* please provide a pristine-tar branch with the metadata of this tarball
* d/control:
+ Vcs-Git is missing, even if Vcs-Browser exist, please add it.
+ These recent days there are guys doing s/cgit/git/ in their
Vcs-Browser, you may consider it too
+ Std-Version is 3.9.8, please check against that
* d/patches/0001-elpa-version.patch:
+ do you have forwarded it?
* d/copyright:
+ line 7 has 'License: GPL', though:
- there is no standalon license paragraph named 'GPL' in d/copygith,
so you are not respecting the format specification
- the license of that file is actually GPL-3+.
Turns out that what's in git is different than what you uploaded, with a
different email address even. Care to explain?
Not just that, the tarball you provide is different than what I can
download from https://github.com/magit/magit-svn/releases in a way that
is actually differnt and not just a repack. Please use what upstream
provides, if you need that diff, then you've got to use a patch.
mattia@chase ~/devel/RFS/magit-svn % diffoscope 2.1.1.tar.gz magit-svn_2.1.1.orig.tar.gz
--- 2.1.1.tar.gz
+++ magit-svn_2.1.1.orig.tar.gz
├── metadata
│ @@ -1 +1 @@
│ -gzip compressed data, from Unix
│ +gzip compressed data, max compression, from Unix
│ --- 2.1.1.tar
├── +++ magit-svn_2.1.1.orig.tar
│ ├── file list
│ │ @@ -1,2 +1,2 @@
│ │ -drwxrwxr-x 0 root (0) root (0) 0 2015-10-18 17:33:27.000000 magit-svn-2.1.1/
│ │ --rw-rw-r-- 0 root (0) root (0) 8718 2015-10-18 17:33:27.000000 magit-svn-2.1.1/magit-svn.el
│ │ +drwxrwxr-x 0 root (0) root (0) 0 2015-12-19 13:47:06.000000 magit-svn-2.1.1/
│ │ +-rw-rw-r-- 0 root (0) root (0) 8758 2015-12-19 13:47:06.000000 magit-svn-2.1.1/magit-svn.el
│ ├── magit-svn-2.1.1/magit-svn.el
│ │ @@ -230,23 +230,25 @@
│ │
│ │ (defun magit-insert-svn-unpushed ()
│ │ (--when-let (magit-svn-get-ref)
│ │ (magit-insert-section (svn-unpushed)
│ │ (magit-insert-heading "Unpushed git commits:")
│ │ (magit-insert-log (format "%s..HEAD" it)))))
│ │
│ │ -(magit-define-section-jumper svn-unpulled "Unpulled svn commits")
│ │ -(magit-define-section-jumper svn-unpushed "Unpushed git commits")
│ │ +(magit-define-section-jumper magit-jump-to-svn-unpulled
│ │ + "Unpulled svn commits" svn-unpulled)
│ │ +(magit-define-section-jumper magit-jump-to-svn-unpushed
│ │ + "Unpushed git commits" svn-unpushed)
│ │
│ │ (defun magit-insert-svn-remote ()
│ │ (--when-let (magit-svn-get-rev)
│ │ (magit-insert-section (line)
│ │ - (magit-insert (format "%-10s%s from %s\n" "Remote:"
│ │ - (propertize (concat "r" it) 'face 'magit-hash)
│ │ - (magit-svn-get-url))))))
│ │ + (insert (format "%-10s%s from %s\n" "Remote:"
│ │ + (propertize (concat "r" it) 'face 'magit-hash)
│ │ + (magit-svn-get-url))))))
│ │
│ │ ;;; magit-svn.el ends soon
│ │
│ │ (define-obsolete-function-alias 'turn-on-magit-svn 'magit-svn-mode)
│ │
│ │ (provide 'magit-svn)
│ │ ;; Local Variables:
│ ╵
╵
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature