Bug#823895: RFS: lsm/1.0.4-1

[Adam Borowski <kilobyte@angband.pl>]

On Sat, May 14, 2016 at 12:22:13AM -0300, Lucas Castro wrote:
> On 13-05-2016 11:46, Adam Borowski wrote:
> >> On 10-05-2016 02:43, Lucas Castro wrote
> >>> I am looking for a sponsor for my package "lsm"
> >>>
> >>>     dget -x https://mentors.debian.net/debian/pool/main/l/lsm/lsm_1.0.4-1.dsc
> >
> > 2. The manpage seems mangled:
> >
> >        While simple to configure, provides easy way reconfigure routes, calling notifyscript
> >
> >        lsmVery configurable, but doesn't support domain names yet.
> Thanks, fixed.

Hmm, it looks like you merely added a space and lowercased V:

       While simple to configure, provides easy way reconfigure routes, calling notifyscript.

       lsm very configurable program, but doesn't support domain names yet.

These two lines don't quite make sense...


> > 3. Typo: exectuble.
> if you mean man page typo, fixed.

It's still in the init script, line 32.


Too bad, when actually trying to install the package:

[....] Starting Link Monitor.: lsminvoke-rc.d: initscript lsm, action "start" failed.
dpkg: error processing package lsm (--install):
 subprocess installed post-installation script returned error exit status 1
Processing triggers for man-db (2.7.5-1) ...
Errors were encountered while processing:
 lsm

[~]# /etc/init.d/lsm start
[....] Starting Link Monitor.: lsm[~]# echo $?
1
(no newline, by the way -- init scripts shouldn't use "set -e")

[~]# lsm --config /etc/lsm/lsm.conf 
[~]# echo $?
1

An error message describing what went wrong would be nice...

Only upon checking the syslog I see:
May 15 00:30:37 umbar lsm[12853]: no targets found in config file
yet according to comments in /etc/lsm/lsm.conf:
# Defaults for the connection entries
# These are set in the code. You may override any values here.
which suggests there's no need to edit the config for basic functionality.

If I read this wrong and some setup is needed, then the package shouldn't
try to start the daemon on initial install, and provide a feedback that
editing the config file is required.

There's no documentation describing what's needed to get lsm running.


Also, it appears the only copy of upstream's changelog is hidden inside
lsm.spec (lines between "%changelog" and "#EOF").  Please cut this (with sed
or a similar tool) and install as /usr/share/doc/*/changelog.gz


In /usr/share/doc/lsm/examples/lsm.conf.sample, there are references to
/usr/libexec/lsm/ instead of /usr/share/lsm/, it'd be nice to sed that to
what's installed on Debian.


> > Meow!
> Done.

Hah!  This was intended as an onomatopeia not an imperative, but I really
like your interpretation :)

-- 
A tit a day keeps the vet away.